Skip to content

Commit cde5c9c

Browse files
committed
Remove redundant Windows installer signing
The signing in `electron-package.sh` is no longer needed, since it's already handled in the new sign script for `electron-builder`.
1 parent 99ee0fc commit cde5c9c

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

scripts/electron-package.sh

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -165,20 +165,6 @@ cp $distdir/squirrel-windows/RELEASES "$pubdir/update/win32/x64/"
165165
# longer appears to work).
166166
cp $distdir/*_amd64.deb "$projdir/electron_app/dist/"
167167

168-
# Now we sign the windows installer executables (as opposed to the main binary which
169-
# is signed in the electron afteSign hook)
170-
echo "Signing Windows installers..."
171-
172-
exe32=( "$distdir"/squirrel-windows-ia32/*.exe )
173-
basename32=`basename "$exe32"`
174-
osslsigncode sign $OSSLSIGNCODE_SIGNARGS -pass "$token_password" -in "$exe32" -out "$projdir/electron_app/pub/install/win32/ia32/$basename32"
175-
176-
exe64=( "$distdir"/squirrel-windows/*.exe )
177-
basename64=`basename "$exe64"`
178-
osslsigncode sign $OSSLSIGNCODE_SIGNARGS -pass "$token_password" -in "$exe64" -out "$projdir/electron_app/pub/install/win32/x64/$basename64"
179-
180-
echo "Installers signed"
181-
182168
rm -rf "$builddir"
183169

184170
echo "$pubdir can now be hosted on your web server."

0 commit comments

Comments
 (0)