Fix Windows signing args

RiotRobot · RiotRobot · commit 99ee0fc72df0 · 2019-11-27T11:54:33.000Z
The hash arg seems to only accept the short `-h` form. In addition, the args in
the environment contained a fixed hash type which is removed here.
diff --git a/electron_app/riot.im/env.sh b/electron_app/riot.im/env.sh
@@ -1 +1 @@
-export OSSLSIGNCODE_SIGNARGS='-pkcs11module /Library/Frameworks/eToken.framework/Versions/Current/libeToken.dylib -pkcs11engine /usr/local/lib/engines/engine_pkcs11.so -certs electron_app/riot.im/New_Vector_Ltd.pem -key 0a3271cbc1ec0fd8afb37f6bbe0cd65ba08d3b4d -t http://timestamp.comodoca.com -h sha256 -verbose'
+export OSSLSIGNCODE_SIGNARGS='-pkcs11module /Library/Frameworks/eToken.framework/Versions/Current/libeToken.dylib -pkcs11engine /usr/local/lib/engines/engine_pkcs11.so -certs electron_app/riot.im/New_Vector_Ltd.pem -key 0a3271cbc1ec0fd8afb37f6bbe0cd65ba08d3b4d -t http://timestamp.comodoca.com -verbose'
diff --git a/scripts/electron_winSign.js b/scripts/electron_winSign.js
@@ -36,14 +36,15 @@ exports.default = async function(options) {
             'tmp_' + Math.random().toString(36).substring(2, 15) + '.exe',
         );
         const args = [
-            '-hash', options.hash,
+            '-h', options.hash,
             '-pass', tokenPassphrase,
             '-in', inPath,
             '-out', tmpFile,
         ];
         if (options.isNest) args.push('-nest');
         cmdLine += shellescape(args);
 
+        console.log("Running", cmdLine);
         const signproc = exec(cmdLine, {}, (error, stdout) => {
             console.log(stdout);
         });

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-export OSSLSIGNCODE_SIGNARGS='-pkcs11module /Library/Frameworks/eToken.framework/Versions/Current/libeToken.dylib -pkcs11engine /usr/local/lib/engines/engine_pkcs11.so -certs electron_app/riot.im/New_Vector_Ltd.pem -key 0a3271cbc1ec0fd8afb37f6bbe0cd65ba08d3b4d -t http://timestamp.comodoca.com -h sha256 -verbose'`
	`1`	`+export OSSLSIGNCODE_SIGNARGS='-pkcs11module /Library/Frameworks/eToken.framework/Versions/Current/libeToken.dylib -pkcs11engine /usr/local/lib/engines/engine_pkcs11.so -certs electron_app/riot.im/New_Vector_Ltd.pem -key 0a3271cbc1ec0fd8afb37f6bbe0cd65ba08d3b4d -t http://timestamp.comodoca.com -verbose'`