Improve step description when compile-webkit step is skipped

aj062 · aj062 · commit 66a202b1f701 · 2021-04-10T11:20:51.000Z
https://bugs.webkit.org/show_bug.cgi?id=224373 Reviewed by Jonathan Bedard. * CISupport/ews-build/steps.py: (CompileWebKit.getResultSummary): Set custom summary when this step is skipped. * CISupport/ews-build/steps_unittest.py: Updated unit-tests. Canonical link: https://commits.webkit.org/236366@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Tools/CISupport/ews-build/steps.py b/Tools/CISupport/ews-build/steps.py
@@ -1595,6 +1595,10 @@ def evaluateCommand(self, cmd):
     def getResultSummary(self):
         if self.results == FAILURE:
             return {'step': 'Failed to compile WebKit'}
+        if self.results == SKIPPED:
+            if self.getProperty('fast_commit_queue'):
+                return {'step': 'Skipped compiling WebKit in fast-cq mode'}
+            return {'step': 'Skipped compiling WebKit'}
         return shell.Compile.getResultSummary(self)
 
 
diff --git a/Tools/CISupport/ews-build/steps_unittest.py b/Tools/CISupport/ews-build/steps_unittest.py
@@ -1121,7 +1121,7 @@ def test_skip_for_revert_patches_on_commit_queue(self):
         self.setProperty('buildername', 'Commit-Queue')
         self.setProperty('configuration', 'debug')
         self.setProperty('fast_commit_queue', True)
-        self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
+        self.expectOutcome(result=SKIPPED, state_string='Skipped compiling WebKit in fast-cq mode')
         return self.runStep()
 
 
@@ -1169,7 +1169,7 @@ def test_skip(self):
         self.setProperty('fullPlatform', 'ios-simulator-11')
         self.setProperty('configuration', 'release')
         self.expectHidden(True)
-        self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
+        self.expectOutcome(result=SKIPPED, state_string='Skipped compiling WebKit')
         return self.runStep()
 
 
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2021-04-10  Aakash Jain  <aakash_jain@apple.com>
+
+        Improve step description when compile-webkit step is skipped
+        https://bugs.webkit.org/show_bug.cgi?id=224373
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/ews-build/steps.py:
+        (CompileWebKit.getResultSummary): Set custom summary when this step is skipped.
+        * CISupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2021-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         REGRESSION (r271660): Tap highlight no longer shows when tapping clickable elements without touch event listeners
