Unreviewed, fix test crashes after r275779

szewai · szewai · commit de4e4e39d50e · 2021-04-10T08:39:13.000Z
https://bugs.webkit.org/show_bug.cgi?id=224305 rdar://71962196 * NetworkProcess/IndexedDB/WebIDBServer.cpp: (WebKit::WebIDBServer::WebIDBServer): rolling back change on setting thread name as we see crash in pthread_setname_np. Canonical link: https://commits.webkit.org/236365@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,13 @@
+2021-04-10  Sihui Liu  <sihui_liu@apple.com>
+
+        Unreviewed, fix test crashes after r275779
+        https://bugs.webkit.org/show_bug.cgi?id=224305
+        rdar://71962196
+
+        * NetworkProcess/IndexedDB/WebIDBServer.cpp:
+        (WebKit::WebIDBServer::WebIDBServer): rolling back change on setting thread name as we see crash in 
+        pthread_setname_np.
+
 2021-04-09  Simon Fraser  <simon.fraser@apple.com>
 
         [iOS WK2] CADisplayLink in the web process is used unintentionally
diff --git a/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp b/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp
@@ -40,7 +40,7 @@ Ref<WebIDBServer> WebIDBServer::create(PAL::SessionID sessionID, const String& d
 }
 
 WebIDBServer::WebIDBServer(PAL::SessionID sessionID, const String& directory, WebCore::IDBServer::IDBServer::StorageQuotaManagerSpaceRequester&& spaceRequester, CompletionHandler<void()>&& callback)
-    : CrossThreadTaskHandler(makeString("com.apple.WebKit.IndexedDBServer.", sessionID.toUInt64()).ascii().data(), WTF::CrossThreadTaskHandler::AutodrainedPoolForRunLoop::Use)
+    : CrossThreadTaskHandler("com.apple.WebKit.IndexedDBServer", WTF::CrossThreadTaskHandler::AutodrainedPoolForRunLoop::Use)
     , m_dataTaskCounter([weakThis = makeWeakPtr(this)](RefCounterEvent) {
         if (weakThis)
             weakThis->tryClose();

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ Ref<WebIDBServer> WebIDBServer::create(PAL::SessionID sessionID, const String& d`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`WebIDBServer::WebIDBServer(PAL::SessionID sessionID, const String& directory, WebCore::IDBServer::IDBServer::StorageQuotaManagerSpaceRequester&& spaceRequester, CompletionHandler<void()>&& callback)`
`43`		`- : CrossThreadTaskHandler(makeString("com.apple.WebKit.IndexedDBServer.", sessionID.toUInt64()).ascii().data(), WTF::CrossThreadTaskHandler::AutodrainedPoolForRunLoop::Use)`
	`43`	`+ : CrossThreadTaskHandler("com.apple.WebKit.IndexedDBServer", WTF::CrossThreadTaskHandler::AutodrainedPoolForRunLoop::Use)`
`44`	`44`	`, m_dataTaskCounter([weakThis = makeWeakPtr(this)](RefCounterEvent) {`
`45`	`45`	`if (weakThis)`
`46`	`46`	`weakThis->tryClose();`