JavaScriptBench
diff --git a/‎Source/WebInspectorUI/ChangeLog‎
Lines changed: 374 additions & 0 deletions b/‎Source/WebInspectorUI/ChangeLog‎
Lines changed: 374 additions & 0 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js‎
Lines changed: 1 addition & 1 deletion b/‎Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js‎
Lines changed: 6 additions & 6 deletions b/‎Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js‎
Lines changed: 6 additions & 6 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js‎
Lines changed: 1 addition & 7 deletions b/‎Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js‎
Lines changed: 1 addition & 7 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js‎
Lines changed: 2 additions & 2 deletions b/‎Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js‎
Lines changed: 2 additions & 2 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js‎
Lines changed: 15 additions & 35 deletions b/‎Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js‎
Lines changed: 15 additions & 35 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js‎
Lines changed: 4 additions & 4 deletions b/‎Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js‎
Lines changed: 4 additions & 4 deletions b/‎Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js‎
Lines changed: 4 additions & 8 deletions b/‎Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js‎
Lines changed: 4 additions & 8 deletions
diff --git a/‎Source/WebInspectorUI/UserInterface/Views/CPUTimelineOverviewGraph.js‎
Lines changed: 3 additions & 1 deletion b/‎Source/WebInspectorUI/UserInterface/Views/CPUTimelineOverviewGraph.js‎
Lines changed: 3 additions & 1 deletion
@@ -279,7 +279,7 @@ WI.JavaScriptLogViewController = class JavaScriptLogViewController extends WI.Ob
         if (messageView.message && messageView.message.source !== WI.ConsoleMessage.MessageSource.JS)
             this._lastCommitted = "";
 
-        if (WI.consoleContentView.visible)
+        if (WI.consoleContentView.isAttached)
             this.renderPendingMessagesSoon();
 
         if (!WI.isShowingConsoleTab() && messageView.message && messageView.message.shouldRevealConsole)
 
@@ -37,16 +37,16 @@ WI.DebugContentView = class DebugContentView extends WI.ContentView
 
     // Protected
 
-    shown()
+    attached()
     {
-        super.shown();
-        console.debug(`shown: ${this._string}`);
+        super.attached();
+        console.debug(`attached: ${this._string}`);
     }
 
-    hidden()
+    detached()
     {
-        console.debug(`hidden: ${this._string}`);
-        super.hidden();
+        console.debug(`detached: ${this._string}`);
+        super.detached();
     }
 
     closed()
 
@@ -73,25 +73,19 @@ WI.BackForwardEntry = class BackForwardEntry
         this._tombstone = tombstone;
     }
 
-    prepareToShow(shouldCallShown)
+    prepareToShow()
     {
         console.assert(!this._tombstone, "Should not be calling shown on a tombstone");
 
         this._restoreFromCookie();
 
-        this.contentView.visible = true;
-        if (shouldCallShown)
-            this.contentView.shown();
         this.contentView.needsLayout();
     }
 
     prepareToHide()
     {
         console.assert(!this._tombstone, "Should not be calling hidden on a tombstone");
 
-        this.contentView.visible = false;
-        this.contentView.hidden();
-
         this._saveScrollPositions();
 
         if (this._contentView.shouldSaveStateWhenHidden) {
 
@@ -142,9 +142,9 @@ WI.AnimationDetailsSidebarPanel = class AnimationDetailsSidebarPanel extends WI.
             codeMirror.refresh();
     }
 
-    shown()
+    attached()
     {
-        super.shown();
+        super.attached();
 
         for (let codeMirror of this._codeMirrorSectionMap.values())
             codeMirror.refresh();
 
@@ -38,27 +38,28 @@ WI.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView ext
         this._emptyView = WI.createMessageTextView(WI.UIString("No Application Cache information available"), false);
         this._emptyView.classList.add("hidden");
         this.element.appendChild(this._emptyView);
+    }
 
-        this._markDirty();
-
-        var status = representedObject.status;
-        this.updateStatus(status);
+    attached()
+    {
+        super.attached();
 
-        WI.applicationCacheManager.addEventListener(WI.ApplicationCacheManager.Event.FrameManifestStatusChanged, this._updateStatus, this);
+        WI.applicationCacheManager.addEventListener(WI.ApplicationCacheManager.Event.FrameManifestStatusChanged, this._handleFrameManifestStatusChanged, this);
+        this.updateStatus(this.representedObject.status);
     }
 
-    shown()
+    detached()
     {
-        super.shown();
+        WI.applicationCacheManager.removeEventListener(WI.ApplicationCacheManager.Event.FrameManifestStatusChanged, this._handleFrameManifestStatusChanged, this);
 
-        this._maybeUpdate();
+        super.detached();
     }
 
-    closed()
+    layout()
     {
-        WI.applicationCacheManager.removeEventListener(WI.ApplicationCacheManager.Event.FrameManifestStatusChanged, this._updateStatus, this);
+        super.layout();
 
-        super.closed();
+        this.updateStatus();
     }
 
     saveToCookie(cookie)
@@ -75,21 +76,7 @@ WI.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView ext
         return [this._dataGrid.scrollContainer];
     }
 
-    _maybeUpdate()
-    {
-        if (!this.visible || !this._viewDirty)
-            return;
-
-        this._update();
-        this._viewDirty = false;
-    }
-
-    _markDirty()
-    {
-        this._viewDirty = true;
-    }
-
-    _updateStatus(event)
+    _handleFrameManifestStatusChanged(event)
     {
         var frameManifest = event.data.frameManifest;
         if (frameManifest !== this.representedObject)
@@ -105,15 +92,8 @@ WI.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView ext
         var oldStatus = this._status;
         this._status = status;
 
-        if (this.visible && this._status === WI.ApplicationCacheManager.Status.Idle && (oldStatus === WI.ApplicationCacheManager.Status.UpdateReady || !this._resources))
-            this._markDirty();
-
-        this._maybeUpdate();
-    }
-
-    _update()
-    {
-        WI.applicationCacheManager.requestApplicationCache(this._frame, this._updateCallback.bind(this));
+        if (this._status === WI.ApplicationCacheManager.Status.Idle && (oldStatus === WI.ApplicationCacheManager.Status.UpdateReady || !this._resources))
+            WI.applicationCacheManager.requestApplicationCache(this._frame, this._updateCallback.bind(this));
     }
 
     _updateCallback(applicationCache)
 
@@ -73,18 +73,18 @@ WI.AuditTabContentView = class AuditTabContentView extends WI.ContentBrowserTabC
             || representedObject instanceof WI.AuditTestGroupResult;
     }
 
-    shown()
+    attached()
     {
-        super.shown();
+        super.attached();
 
         this._startStopShortcut.disabled = false;
     }
 
-    hidden()
+    detached()
     {
         this._startStopShortcut.disabled = true;
 
-        super.hidden();
+        super.detached();
     }
 
     // DropZoneView delegate
 
@@ -258,9 +258,9 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
         this._updateExportNavigationItems();
     }
 
-    shown()
+    attached()
     {
-        super.shown();
+        super.attached();
 
         if (this.representedObject instanceof WI.AuditTestBase) {
             this.representedObject.addEventListener(WI.AuditTestBase.Event.Completed, this._handleTestChanged, this);
@@ -275,7 +275,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
         }
     }
 
-    hidden()
+    detached()
     {
         if (this.representedObject instanceof WI.AuditTestBase) {
             this.representedObject.removeEventListener(WI.AuditTestBase.Event.Completed, this._handleTestChanged, this);
@@ -289,7 +289,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView
             WI.auditManager.removeEventListener(WI.AuditManager.Event.EditingChanged, this._handleEditingChanged, this);
         }
 
-        super.hidden();
+        super.detached();
     }
 
     handleResultChanged(event)
 
@@ -194,9 +194,9 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
             this.showFilteredPlaceholder();
     }
 
-    shown()
+    attached()
     {
-        super.shown();
+        super.attached();
 
         if (this.representedObject instanceof WI.AuditTestGroup) {
             this.representedObject.addEventListener(WI.AuditTestBase.Event.Progress, this._handleTestGroupProgress, this);
@@ -213,7 +213,7 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
             this._addTest(subobject);
     }
 
-    hidden()
+    detached()
     {
         if (this.representedObject instanceof WI.AuditTestGroup) {
             this.representedObject.removeEventListener(WI.AuditTestBase.Event.Progress, this._handleTestGroupProgress, this);
@@ -225,12 +225,10 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
             }
         }
 
-        for (let view of this._viewForSubobject.values())
-            view.hidden();
         this.contentView.removeAllSubviews();
         this._viewForSubobject.clear();
 
-        super.hidden();
+        super.detached();
     }
 
     applyFilter(levels)
@@ -317,7 +315,6 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
 
         let view = WI.ContentView.contentViewForRepresentedObject(test);
         this.contentView.addSubview(view);
-        view.shown();
 
         this._viewForSubobject.set(test, view);
     }
@@ -355,7 +352,6 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
         let view = this._viewForSubobject.get(test);
         console.assert(view);
 
-        view.hidden();
         this.contentView.removeSubview(view);
 
         this._updateClassList();
 
@@ -78,7 +78,9 @@ WI.CPUTimelineOverviewGraph = class CPUTimelineOverviewGraph extends WI.Timeline
 
     layout()
     {
-        if (!this.visible)
+        super.layout();
+
+        if (this.hidden)
             return;
 
         this._updateLegend();
Original file line number	Diff line number	Diff line change
`@@ -37,16 +37,16 @@ WI.DebugContentView = class DebugContentView extends WI.ContentView`
`37`	`37`
`38`	`38`	`// Protected`
`39`	`39`
`40`		`- shown()`
	`40`	`+ attached()`
`41`	`41`	`{`
`42`		`- super.shown();`
`43`		- console.debug(`shown: ${this._string}`);
	`42`	`+ super.attached();`
	`43`	+ console.debug(`attached: ${this._string}`);
`44`	`44`	`}`
`45`	`45`
`46`		`- hidden()`
	`46`	`+ detached()`
`47`	`47`	`{`
`48`		- console.debug(`hidden: ${this._string}`);
`49`		`- super.hidden();`
	`48`	+ console.debug(`detached: ${this._string}`);
	`49`	`+ super.detached();`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`closed()`
Original file line number	Diff line number	Diff line change
`@@ -73,25 +73,19 @@ WI.BackForwardEntry = class BackForwardEntry`
`73`	`73`	`this._tombstone = tombstone;`
`74`	`74`	`}`
`75`	`75`
`76`		`- prepareToShow(shouldCallShown)`
	`76`	`+ prepareToShow()`
`77`	`77`	`{`
`78`	`78`	`console.assert(!this._tombstone, "Should not be calling shown on a tombstone");`
`79`	`79`
`80`	`80`	`this._restoreFromCookie();`
`81`	`81`
`82`		`- this.contentView.visible = true;`
`83`		`- if (shouldCallShown)`
`84`		`- this.contentView.shown();`
`85`	`82`	`this.contentView.needsLayout();`
`86`	`83`	`}`
`87`	`84`
`88`	`85`	`prepareToHide()`
`89`	`86`	`{`
`90`	`87`	`console.assert(!this._tombstone, "Should not be calling hidden on a tombstone");`
`91`	`88`
`92`		`- this.contentView.visible = false;`
`93`		`- this.contentView.hidden();`
`94`		`-`
`95`	`89`	`this._saveScrollPositions();`
`96`	`90`
`97`	`91`	`if (this._contentView.shouldSaveStateWhenHidden) {`
Original file line number	Diff line number	Diff line change
`@@ -142,9 +142,9 @@ WI.AnimationDetailsSidebarPanel = class AnimationDetailsSidebarPanel extends WI.`
`142`	`142`	`codeMirror.refresh();`
`143`	`143`	`}`
`144`	`144`
`145`		`- shown()`
	`145`	`+ attached()`
`146`	`146`	`{`
`147`		`- super.shown();`
	`147`	`+ super.attached();`
`148`	`148`
`149`	`149`	`for (let codeMirror of this._codeMirrorSectionMap.values())`
`150`	`150`	`codeMirror.refresh();`
Original file line number	Diff line number	Diff line change
`@@ -73,18 +73,18 @@ WI.AuditTabContentView = class AuditTabContentView extends WI.ContentBrowserTabC`
`73`	`73`	`\|\| representedObject instanceof WI.AuditTestGroupResult;`
`74`	`74`	`}`
`75`	`75`
`76`		`- shown()`
	`76`	`+ attached()`
`77`	`77`	`{`
`78`		`- super.shown();`
	`78`	`+ super.attached();`
`79`	`79`
`80`	`80`	`this._startStopShortcut.disabled = false;`
`81`	`81`	`}`
`82`	`82`
`83`		`- hidden()`
	`83`	`+ detached()`
`84`	`84`	`{`
`85`	`85`	`this._startStopShortcut.disabled = true;`
`86`	`86`
`87`		`- super.hidden();`
	`87`	`+ super.detached();`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`// DropZoneView delegate`
Original file line number	Diff line number	Diff line change
`@@ -258,9 +258,9 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView`
`258`	`258`	`this._updateExportNavigationItems();`
`259`	`259`	`}`
`260`	`260`
`261`		`- shown()`
	`261`	`+ attached()`
`262`	`262`	`{`
`263`		`- super.shown();`
	`263`	`+ super.attached();`
`264`	`264`
`265`	`265`	`if (this.representedObject instanceof WI.AuditTestBase) {`
`266`	`266`	`this.representedObject.addEventListener(WI.AuditTestBase.Event.Completed, this._handleTestChanged, this);`
`@@ -275,7 +275,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView`
`275`	`275`	`}`
`276`	`276`	`}`
`277`	`277`
`278`		`- hidden()`
	`278`	`+ detached()`
`279`	`279`	`{`
`280`	`280`	`if (this.representedObject instanceof WI.AuditTestBase) {`
`281`	`281`	`this.representedObject.removeEventListener(WI.AuditTestBase.Event.Completed, this._handleTestChanged, this);`
`@@ -289,7 +289,7 @@ WI.AuditTestContentView = class AuditTestContentView extends WI.ContentView`
`289`	`289`	`WI.auditManager.removeEventListener(WI.AuditManager.Event.EditingChanged, this._handleEditingChanged, this);`
`290`	`290`	`}`
`291`	`291`
`292`		`- super.hidden();`
	`292`	`+ super.detached();`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`handleResultChanged(event)`
Original file line number	Diff line number	Diff line change
`@@ -194,9 +194,9 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT`
`194`	`194`	`this.showFilteredPlaceholder();`
`195`	`195`	`}`
`196`	`196`
`197`		`- shown()`
	`197`	`+ attached()`
`198`	`198`	`{`
`199`		`- super.shown();`
	`199`	`+ super.attached();`
`200`	`200`
`201`	`201`	`if (this.representedObject instanceof WI.AuditTestGroup) {`
`202`	`202`	`this.representedObject.addEventListener(WI.AuditTestBase.Event.Progress, this._handleTestGroupProgress, this);`
`@@ -213,7 +213,7 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT`
`213`	`213`	`this._addTest(subobject);`
`214`	`214`	`}`
`215`	`215`
`216`		`- hidden()`
	`216`	`+ detached()`
`217`	`217`	`{`
`218`	`218`	`if (this.representedObject instanceof WI.AuditTestGroup) {`
`219`	`219`	`this.representedObject.removeEventListener(WI.AuditTestBase.Event.Progress, this._handleTestGroupProgress, this);`
`@@ -225,12 +225,10 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT`
`225`	`225`	`}`
`226`	`226`	`}`
`227`	`227`
`228`		`- for (let view of this._viewForSubobject.values())`
`229`		`- view.hidden();`
`230`	`228`	`this.contentView.removeAllSubviews();`
`231`	`229`	`this._viewForSubobject.clear();`
`232`	`230`
`233`		`- super.hidden();`
	`231`	`+ super.detached();`
`234`	`232`	`}`
`235`	`233`
`236`	`234`	`applyFilter(levels)`
`@@ -317,7 +315,6 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT`
`317`	`315`
`318`	`316`	`let view = WI.ContentView.contentViewForRepresentedObject(test);`
`319`	`317`	`this.contentView.addSubview(view);`
`320`		`- view.shown();`
`321`	`318`
`322`	`319`	`this._viewForSubobject.set(test, view);`
`323`	`320`	`}`
`@@ -355,7 +352,6 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT`
`355`	`352`	`let view = this._viewForSubobject.get(test);`
`356`	`353`	`console.assert(view);`
`357`	`354`
`358`		`- view.hidden();`
`359`	`355`	`this.contentView.removeSubview(view);`
`360`	`356`
`361`	`357`	`this._updateClassList();`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,9 @@ WI.CPUTimelineOverviewGraph = class CPUTimelineOverviewGraph extends WI.Timeline`
`78`	`78`
`79`	`79`	`layout()`
`80`	`80`	`{`
`81`		`- if (!this.visible)`
	`81`	`+ super.layout();`
	`82`	`+`
	`83`	`+ if (this.hidden)`
`82`	`84`	`return;`
`83`	`85`
`84`	`86`	`this._updateLegend();`