Skip to content

Commit 34341e0

Browse files
lauromouralauromoura
committed
[GTK][WPE] Rebaseline and gardening
Unreviewed test gardening. The meter and progress tests had to be rebaselined and split after r270044. * platform/glib/TestExpectations: Add missing entries. * platform/glib/fast/dom/HTMLProgressElement/progress-element-expected.txt: * platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt: Removed. Uneeded after r269972. * platform/glib/webaudio/audioworklet-addModule-failure-expected.txt: Rebaseline after r270033. * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-expected.txt. * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Rebaselined after r270023. * platform/glib/TestExpectations: Remove entry after test removal. * platform/wpe/fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt. * platform/wpe/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt. * platform/wpe/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-expected.txt. * platform/wpe/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Rebaselined after r270023. Canonical link: https://commits.webkit.org/231842@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent a3e58f1 commit 34341e0

16 files changed

Lines changed: 274 additions & 112 deletions

‎LayoutTests/ChangeLog‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,32 @@
1+
2020-11-20 Lauro Moura <lmoura@igalia.com>
2+
3+
[GTK][WPE] Rebaseline and gardening
4+
5+
Unreviewed test gardening.
6+
7+
The meter and progress tests had to be rebaselined and split after
8+
r270044.
9+
10+
* platform/glib/TestExpectations: Add missing entries.
11+
* platform/glib/fast/dom/HTMLProgressElement/progress-element-expected.txt:
12+
* platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt:
13+
Removed. Uneeded after r269972.
14+
* platform/glib/webaudio/audioworklet-addModule-failure-expected.txt:
15+
Rebaseline after r270033.
16+
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt.
17+
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt.
18+
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-expected.txt.
19+
* platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
20+
* platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
21+
Rebaselined after r270023.
22+
* platform/glib/TestExpectations: Remove entry after test removal.
23+
* platform/wpe/fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt.
24+
* platform/wpe/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt.
25+
* platform/wpe/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-expected.txt.
26+
* platform/wpe/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
27+
* platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
28+
Rebaselined after r270023.
29+
130
2020-11-20 Truitt Savell <tsavell@apple.com>
231

332
Revert r270124. Made the test worse.

‎LayoutTests/platform/glib/TestExpectations‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,7 @@ webkit.org/b/218931 fast/events/wheel/wheel-event-listeners-on-body-made-passive
356356
webkit.org/b/218931 fast/events/wheel/wheel-event-listeners-on-document-made-passive.html [ Timeout ]
357357
webkit.org/b/218931 fast/events/wheel/wheel-event-listeners-on-window-left-active.html [ Timeout ]
358358
webkit.org/b/218931 fast/events/wheel/wheel-event-listeners-on-window-made-passive.html [ Timeout ]
359+
webkit.org/b/218931 fast/events/wheel/wheel-event-in-passive-region-non-cancelable.html [ Timeout ]
359360

360361
#////////////////////////////////////////////////////////////////////////////////////////
361362
# End of Events-related bugs

‎LayoutTests/platform/glib/fast/dom/HTMLProgressElement/progress-element-expected.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ layer at (0,0) size 800x600
33
layer at (0,0) size 800x600
44
RenderBlock {HTML} at (0,0) size 800x600
55
RenderBody {BODY} at (8,8) size 784x584
6-
RenderProgress {PROGRESS} at (0,0) size 160x7
6+
RenderProgress {PROGRESS} at (0,1) size 160x7
77
RenderInline {SMALL} at (0,0) size 134x15
8-
RenderProgress {PROGRESS} at (160,-1) size 134x7
8+
RenderProgress {PROGRESS} at (160,0) size 134x7
99
RenderText {#text} at (0,0) size 0x0

‎LayoutTests/platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt‎

Lines changed: 0 additions & 49 deletions
This file was deleted.

‎LayoutTests/platform/glib/webaudio/audioworklet-addModule-failure-expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
44

55

66
PASS context.audioWorklet.addModule(invalidURL); rejected promise with SyntaxError: Module URL is invalid.
7-
PASS context.audioWorklet.addModule('doesnotExist.js'); rejected promise with NetworkError: Failed to fetch module, error: Error opening file /app/webkit/LayoutTests/webaudio/doesnotExist.js: No such file or directory.
7+
PASS context.audioWorklet.addModule('doesnotExist.js'); rejected promise with AbortError: Failed to fetch module, error: Error opening file /app/webkit/LayoutTests/webaudio/doesnotExist.js: No such file or directory.
88
PASS successfullyParsed is true
99

1010
TEST COMPLETE

LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-element-expected.txt renamed to LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ layer at (0,0) size 800x600
33
layer at (0,0) size 800x600
44
RenderBlock {HTML} at (0,0) size 800x600
55
RenderBody {BODY} at (8,8) size 784x584
6-
RenderBlock {METER} at (0,43) size 80x17
6+
RenderBlock {METER} at (0,44) size 80x17
77
RenderBlock {DIV} at (0,0) size 80x16
88
RenderBlock {DIV} at (0,0) size 80x16
99
RenderBlock {DIV} at (0,0) size 18x16
10-
RenderBlock {METER} at (80,-1) size 10x61
10+
RenderBlock {METER} at (80,0) size 10x61
1111
RenderBlock {DIV} at (0,0) size 10x60
1212
RenderBlock {DIV} at (0,0) size 10x60
1313
RenderBlock {DIV} at (0,0) size 7x60

LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt renamed to LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ layer at (0,0) size 800x600
99
RenderBlock {P} at (0,58) size 784x19
1010
RenderText {#text} at (0,0) size 647x17
1111
text run at (0,0) width 647: "Following meter gauge should be solid green - Changing the paseudo class by changing value attribute"
12-
RenderBlock (anonymous) at (0,92) size 784x16
13-
RenderBlock {METER} at (0,-1) size 80x17
12+
RenderBlock (anonymous) at (0,92) size 784x17
13+
RenderBlock {METER} at (0,0) size 80x17
1414
RenderBlock {DIV} at (0,0) size 80x16
1515
RenderBlock {DIV} at (0,0) size 80x16 [bgcolor=#808080]
1616
RenderBlock {DIV} at (0,0) size 72x16 [bgcolor=#008000]

LayoutTests/platform/glib/fast/dom/HTMLMeterElement/meter-styles-expected.txt renamed to LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ layer at (0,0) size 800x600
66
RenderBlock {H2} at (3,0) size 778x18
77
RenderText {#text} at (0,0) size 350x17
88
text run at (0,0) width 350: "Horizontal meters with the non-themed default style"
9-
RenderBlock {UL} at (3,21) size 778x62
9+
RenderBlock {UL} at (3,21) size 778x63
1010
RenderListItem {LI} at (43,0) size 732x18
1111
RenderBlock {METER} at (0,1) size 80x17
1212
RenderBlock {DIV} at (0,0) size 80x16
@@ -24,28 +24,28 @@ layer at (0,0) size 800x600
2424
RenderBlock {DIV} at (0,0) size 80x16
2525
RenderBlock {DIV} at (0,0) size 80x16
2626
RenderBlock {DIV} at (0,0) size 60x16
27-
RenderListItem {LI} at (43,21) size 732x41
28-
RenderBlock {METER} at (0,-1) size 30x41
27+
RenderListItem {LI} at (43,21) size 732x42
28+
RenderBlock {METER} at (0,0) size 30x41
2929
RenderBlock {DIV} at (0,0) size 30x40
3030
RenderBlock {DIV} at (0,0) size 30x40
3131
RenderBlock {DIV} at (0,0) size 8x40
32-
RenderText {#text} at (30,22) size 4x17
33-
text run at (30,22) width 4: " "
34-
RenderBlock {METER} at (34,-1) size 30x41
32+
RenderText {#text} at (30,23) size 4x17
33+
text run at (30,23) width 4: " "
34+
RenderBlock {METER} at (34,0) size 30x41
3535
RenderBlock {DIV} at (0,0) size 30x40
3636
RenderBlock {DIV} at (0,0) size 30x40
3737
RenderBlock {DIV} at (0,0) size 14x40
38-
RenderText {#text} at (64,22) size 4x17
39-
text run at (64,22) width 4: " "
40-
RenderBlock {METER} at (68,-1) size 30x41
38+
RenderText {#text} at (64,23) size 4x17
39+
text run at (64,23) width 4: " "
40+
RenderBlock {METER} at (68,0) size 30x41
4141
RenderBlock {DIV} at (0,0) size 30x40
4242
RenderBlock {DIV} at (0,0) size 30x40
4343
RenderBlock {DIV} at (0,0) size 23x40
44-
RenderBlock {H2} at (3,85) size 778x19
44+
RenderBlock {H2} at (3,86) size 778x19
4545
RenderText {#text} at (0,0) size 150x17
4646
text run at (0,0) width 150: "Providing meter styles"
47-
RenderBlock {DIV} at (0,106) size 784x70 [bgcolor=#EEEEEE]
48-
RenderBlock {UL} at (3,0) size 778x69
47+
RenderBlock {DIV} at (0,107) size 784x71 [bgcolor=#EEEEEE]
48+
RenderBlock {UL} at (3,0) size 778x70
4949
RenderListItem {LI} at (43,0) size 732x18
5050
RenderBlock {METER} at (0,1) size 80x17 [bgcolor=#AAAACC] [border: (5px solid #222244) (20px solid #222244) (5px solid #222244) (10px solid #222244)]
5151
RenderBlock {DIV} at (10,5) size 50x6
@@ -60,17 +60,17 @@ layer at (0,0) size 800x600
6060
RenderBlock {DIV} at (0,0) size 40x6
6161
RenderText {#text} at (80,0) size 80x17
6262
text run at (80,0) width 80: " has padding"
63-
RenderListItem {LI} at (43,42) size 732x27
64-
RenderBlock {METER} at (10,4) size 80x17 [bgcolor=#AAAACC]
63+
RenderListItem {LI} at (43,42) size 732x28
64+
RenderBlock {METER} at (10,5) size 80x17 [bgcolor=#AAAACC]
6565
RenderBlock {DIV} at (0,0) size 80x16
6666
RenderBlock {DIV} at (0,0) size 80x16
6767
RenderBlock {DIV} at (0,0) size 64x16
68-
RenderText {#text} at (110,8) size 73x17
69-
text run at (110,8) width 73: " has margin"
70-
RenderBlock {H2} at (3,178) size 778x19
68+
RenderText {#text} at (110,9) size 73x17
69+
text run at (110,9) width 73: " has margin"
70+
RenderBlock {H2} at (3,180) size 778x19
7171
RenderText {#text} at (0,0) size 224x17
7272
text run at (0,0) width 224: "Providing bar and/or value styles"
73-
RenderBlock {DIV} at (0,199) size 784x167 [bgcolor=#EEEEEE]
73+
RenderBlock {DIV} at (0,201) size 784x167 [bgcolor=#EEEEEE]
7474
RenderBlock {UL} at (3,0) size 778x82
7575
RenderBlock (anonymous) at (40,0) size 738x18
7676
RenderText {#text} at (0,0) size 475x17
@@ -121,10 +121,10 @@ layer at (0,0) size 800x600
121121
RenderBlock {DIV} at (2,2) size 61x12 [bgcolor=#008000] [border: (2px solid #77CC77)]
122122
RenderText {#text} at (80,0) size 235x17
123123
text run at (80,0) width 235: " should have solid bar and value part."
124-
RenderBlock {H2} at (3,369) size 778x18
124+
RenderBlock {H2} at (3,371) size 778x18
125125
RenderText {#text} at (0,0) size 156x17
126126
text run at (0,0) width 156: "Providing appearances"
127-
RenderBlock {DIV} at (0,390) size 784x40 [bgcolor=#EEEEEE]
127+
RenderBlock {DIV} at (0,392) size 784x40 [bgcolor=#EEEEEE]
128128
RenderBlock {UL} at (3,0) size 778x40
129129
RenderListItem {LI} at (43,0) size 732x18
130130
RenderBlock {METER} at (0,1) size 80x17
@@ -140,10 +140,10 @@ layer at (0,0) size 800x600
140140
RenderBlock {DIV} at (0,0) size 64x16
141141
RenderText {#text} at (80,0) size 276x17
142142
text run at (80,0) width 276: " has \"meter\" appearance, should be themed."
143-
RenderBlock {H2} at (3,432) size 778x19
143+
RenderBlock {H2} at (3,434) size 778x19
144144
RenderText {#text} at (0,0) size 161x17
145145
text run at (0,0) width 161: "Providing bar paddings"
146-
RenderBlock {DIV} at (0,453) size 784x19 [bgcolor=#EEEEEE]
146+
RenderBlock {DIV} at (0,455) size 784x19 [bgcolor=#EEEEEE]
147147
RenderBlock {METER} at (0,1) size 80x17
148148
RenderBlock {DIV} at (0,0) size 80x16
149149
RenderBlock {DIV} at (0,0) size 80x16

0 commit comments

Comments
 (0)