Skip to content

Commit e6c88ea

Browse files
committed
[1.7>master] [MERGE chakra-core#3634 @xiaoyinl] Remove undefined functions in ScriptContext.h
Merge pull request chakra-core#3634 from xiaoyinl:function_cleanup These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp: [LeaveScriptStartCore](https://github.com/Microsoft/ChakraCore/search?q=LeaveScriptStartCore), [CleanEvalMapCache](https://github.com/Microsoft/ChakraCore/search?q=CleanEvalMapCache), [AddFunctionBodyToPropIdMap](https://github.com/Microsoft/ChakraCore/search?q=AddFunctionBodyToPropIdMap). I wonder if we can remove them, since they are not used.
2 parents c1c000b + 9753783 commit e6c88ea

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

lib/Runtime/Base/ScriptContext.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -924,7 +924,6 @@ namespace Js
924924
char16 const * url;
925925

926926
void PrintStats();
927-
BOOL LeaveScriptStartCore(void * frameAddress, bool leaveForHost);
928927

929928
void InternalClose();
930929

@@ -1061,7 +1060,6 @@ namespace Js
10611060

10621061
template <typename TCacheType>
10631062
void CleanDynamicFunctionCache(TCacheType* cacheType);
1064-
void CleanEvalMapCache(Js::EvalCacheTopLevelDictionary * cacheType);
10651063

10661064
template <class TDelegate>
10671065
void MapFunction(TDelegate mapper);
@@ -1197,7 +1195,6 @@ namespace Js
11971195
void SetFastDOMenabled();
11981196
BOOL VerifyAlive(BOOL isJSFunction = FALSE, ScriptContext* requestScriptContext = nullptr);
11991197
void VerifyAliveWithHostContext(BOOL isJSFunction, HostScriptContext* requestHostScriptContext);
1200-
void AddFunctionBodyToPropIdMap(FunctionBody* body);
12011198

12021199
void BindReference(void* addr);
12031200

0 commit comments

Comments
 (0)