Skip to content

Commit 9753783

Browse files
committed
[MERGE chakra-core#3634 @xiaoyinl] Remove undefined functions in ScriptContext.h
Merge pull request chakra-core#3634 from xiaoyinl:function_cleanup These member functions are declared in ScriptContext.h, but are not defined in ScriptContext.cpp: [LeaveScriptStartCore](https://github.com/Microsoft/ChakraCore/search?q=LeaveScriptStartCore), [CleanEvalMapCache](https://github.com/Microsoft/ChakraCore/search?q=CleanEvalMapCache), [AddFunctionBodyToPropIdMap](https://github.com/Microsoft/ChakraCore/search?q=AddFunctionBodyToPropIdMap). I wonder if we can remove them, since they are not used.
2 parents 2e48b60 + b966a9d commit 9753783

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

lib/Runtime/Base/ScriptContext.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,6 @@ namespace Js
914914
char16 const * url;
915915

916916
void PrintStats();
917-
BOOL LeaveScriptStartCore(void * frameAddress, bool leaveForHost);
918917

919918
void InternalClose();
920919

@@ -1065,7 +1064,6 @@ namespace Js
10651064

10661065
template <typename TCacheType>
10671066
void CleanDynamicFunctionCache(TCacheType* cacheType);
1068-
void CleanEvalMapCache(Js::EvalCacheTopLevelDictionary * cacheType);
10691067

10701068
template <class TDelegate>
10711069
void MapFunction(TDelegate mapper);
@@ -1201,7 +1199,6 @@ namespace Js
12011199
void SetFastDOMenabled();
12021200
BOOL VerifyAlive(BOOL isJSFunction = FALSE, ScriptContext* requestScriptContext = nullptr);
12031201
void VerifyAliveWithHostContext(BOOL isJSFunction, HostScriptContext* requestHostScriptContext);
1204-
void AddFunctionBodyToPropIdMap(FunctionBody* body);
12051202

12061203
void BindReference(void* addr);
12071204

0 commit comments

Comments
 (0)