[MERGE chakra-core#4442 @MikeHolman] fix infinite loop in ProcessContext registration

MikeHolman · MikeHolman · commit d81df87e889d · 2017-12-18T19:07:18.000-08:00
Merge pull request chakra-core#4442 from MikeHolman:contextremoval
diff --git a/lib/JITServer/JITServer.cpp b/lib/JITServer/JITServer.cpp
@@ -885,8 +885,7 @@ HRESULT
 ProcessContextManager::RegisterNewProcess(DWORD pid, HANDLE processHandle, intptr_t chakraBaseAddress, intptr_t crtBaseAddress)
 {
     AutoCriticalSection autoCS(&cs);
-    auto iter = ProcessContexts.GetIteratorWithRemovalSupport();
-    while (iter.IsValid())
+    for (auto iter = ProcessContexts.GetIteratorWithRemovalSupport(); iter.IsValid(); iter.MoveNext())
     {
         ProcessContext* context = iter.CurrentValue();
         // We can delete a ProcessContext if no ThreadContexts refer to it and the process is terminated

Original file line number	Diff line number	Diff line change
`@@ -885,8 +885,7 @@ HRESULT`
`885`	`885`	`ProcessContextManager::RegisterNewProcess(DWORD pid, HANDLE processHandle, intptr_t chakraBaseAddress, intptr_t crtBaseAddress)`
`886`	`886`	`{`
`887`	`887`	`AutoCriticalSection autoCS(&cs);`
`888`		`- auto iter = ProcessContexts.GetIteratorWithRemovalSupport();`
`889`		`- while (iter.IsValid())`
	`888`	`+ for (auto iter = ProcessContexts.GetIteratorWithRemovalSupport(); iter.IsValid(); iter.MoveNext())`
`890`	`889`	`{`
`891`	`890`	`ProcessContext* context = iter.CurrentValue();`
`892`	`891`	`// We can delete a ProcessContext if no ThreadContexts refer to it and the process is terminated`