fix infinite loop in ProcessContext registration

MikeHolman · MikeHolman · commit 3e105e76e6fd · 2017-12-18T18:13:55.000-08:00
diff --git a/lib/JITServer/JITServer.cpp b/lib/JITServer/JITServer.cpp
@@ -872,8 +872,7 @@ HRESULT
 ProcessContextManager::RegisterNewProcess(DWORD pid, HANDLE processHandle, intptr_t chakraBaseAddress, intptr_t crtBaseAddress)
 {
     AutoCriticalSection autoCS(&cs);
-    auto iter = ProcessContexts.GetIteratorWithRemovalSupport();
-    while (iter.IsValid())
+    for (auto iter = ProcessContexts.GetIteratorWithRemovalSupport(); iter.IsValid(); iter.MoveNext())
     {
         ProcessContext* context = iter.CurrentValue();
         // We can delete a ProcessContext if no ThreadContexts refer to it and the process is terminated

Original file line number	Diff line number	Diff line change
`@@ -872,8 +872,7 @@ HRESULT`
`872`	`872`	`ProcessContextManager::RegisterNewProcess(DWORD pid, HANDLE processHandle, intptr_t chakraBaseAddress, intptr_t crtBaseAddress)`
`873`	`873`	`{`
`874`	`874`	`AutoCriticalSection autoCS(&cs);`
`875`		`- auto iter = ProcessContexts.GetIteratorWithRemovalSupport();`
`876`		`- while (iter.IsValid())`
	`875`	`+ for (auto iter = ProcessContexts.GetIteratorWithRemovalSupport(); iter.IsValid(); iter.MoveNext())`
`877`	`876`	`{`
`878`	`877`	`ProcessContext* context = iter.CurrentValue();`
`879`	`878`	`// We can delete a ProcessContext if no ThreadContexts refer to it and the process is terminated`