Repository navigation
Replace localhost with private IP ranges fetcher - #32
Conversation
JasonLovesDoggo
left a comment
There was a problem hiding this comment.
I do feel like the name private fetcher is a little lacking in detail but I couldn't think of anything better so that gets a pass for me.
| func (f PrivateFetcher) FetchIPRanges() ([]string, error) { | ||
|
|
||
| return []string{ | ||
| "127.0.0.0/8", |
There was a problem hiding this comment.
Would be nice if we could remove the overlapping IPS with localhost fetcher
There was a problem hiding this comment.
I wasn't sure about that, but I'll change it.
There was a problem hiding this comment.
I was trying to keep it close to Caddy, by the way: https://caddyserver.com/docs/caddyfile/matchers#remote-ip
|
Actually, thinking about it for a minute. I feel like this could be instead layered on top of the localhost fetcher. Perhaps rename that to local fetcher and add the missing CIDRs there Sorry for the scattered replies, I'm just replying on my phone |
544f807 to
951f0f6
Compare
The problem is, from a network perspective private IP ranges are not required to be local. 😁 |
619b1c0 to
11ac0ab
Compare
True! I really just created the localhost fetcher for development of this plugin. Not much thought was put into it. You're welcome to update the PR so this new module is a direct replacement for the localhost fetcher |
11ac0ab to
f910338
Compare
|
LGTM! Thanks for the contributions! |
If #33 is merged, this needs a rebase.