Repository navigation
Allow making a POST request with an ArrayBuffer body - #227
Conversation
262d5fb to
218b13d
Compare
|
The travis tests are failing with this error, which I'm not able to reproduce locally, but I don't think it relates to my changes. Any tips are appreciated. |
There was a problem hiding this comment.
Can you explain why was this particular change needed?
There was a problem hiding this comment.
Whoops! Good catch. That was some code I had in to debug what turned out to be an unrelated issue. I've since removed this change.
|
I'm sorry for the CI failure, it wasn't your fault. I just updated master with an attempted fix for CI. Can you merge master into your branch and push to update this PR? It should get the CI passing. Thanks |
218b13d to
7d91926
Compare
|
Ok, I rebased onto master, but it looks like one of the jobs is still failing. Is there a way I can see which tests are failing? I'm not seeing it in the build output on travis. |
|
It failed for IE 9. You'll probably have to skip your added test on browsers that don't support ArrayBuffer. |
7d91926 to
1529c83
Compare
|
@mislav - Looks like the tests passed this time. Are there any other concerns you have? |
Allow making a POST request with an ArrayBuffer body
|
Thanks! |
|
Would it be possible to get a new npm release with this code? If now's not the right time, that's fine - we can use a full git url for the time being. |
|
I've pushed a tag right now. Should appear on npm automatically. |
|
Hmm, I think something may have gone wrong with that automated release process. I don't see the new release on npm yet. Or, perhaps, it's just very slow; feel free to say "be patient!". |
|
Hm something went wrong with auto-publishing to npm from Travis CI. I published manually now. |
|
Looks good, thanks! |
This enables POSTing with an ArrayBuffer body, but doesn't change the existing support for receiving ArrayBuffer responses (via blob)