Skip to content

feat: enhance ALTER TABLE support with UNIQUE KEY and INVISIBLE index #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 3 commits into from
Apr 30, 2025
+225 −95
Merged

feat: enhance ALTER TABLE support with UNIQUE KEY and INVISIBLE index #2234

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f029697
feat: enhance ALTER TABLE support with UNIQUE KEY and INVISIBLE index…
minleejae Apr 30, 2025
6e70f25
test: add unit test for ALTER TABLE with INVISIBLE index option
minleejae Apr 30, 2025
6b2b5e7
fix formatting
minleejae Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add unit test for ALTER TABLE with INVISIBLE index option
  • Loading branch information
@minleejae
minleejae committed Apr 30, 2025
commit 6e70f25532888ee2c9d505b3c0c8809eae900160
60 changes: 52 additions & 8 deletions src/test/java/net/sf/jsqlparser/statement/alter/AlterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,22 @@
*/
package net.sf.jsqlparser.statement.alter;

import static net.sf.jsqlparser.test.TestUtils.*;
import static org.junit.jupiter.api.Assertions.*;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.stream.Stream;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;

import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.expression.StringValue;
import net.sf.jsqlparser.expression.operators.relational.NotEqualsTo;
Expand All @@ -28,12 +37,16 @@
import net.sf.jsqlparser.statement.Statement;
import net.sf.jsqlparser.statement.alter.AlterExpression.ColumnDataType;
import net.sf.jsqlparser.statement.create.index.CreateIndex;
import net.sf.jsqlparser.statement.create.table.*;
import net.sf.jsqlparser.statement.create.table.CheckConstraint;
import net.sf.jsqlparser.statement.create.table.ForeignKeyIndex;
import net.sf.jsqlparser.statement.create.table.Index;
import net.sf.jsqlparser.statement.create.table.Index.ColumnParams;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import net.sf.jsqlparser.statement.create.table.NamedConstraint;
import net.sf.jsqlparser.statement.create.table.PartitionDefinition;
import static net.sf.jsqlparser.test.TestUtils.assertDeparse;
import static net.sf.jsqlparser.test.TestUtils.assertEqualsObjectTree;
import static net.sf.jsqlparser.test.TestUtils.assertSqlCanBeParsedAndDeparsed;
import static net.sf.jsqlparser.test.TestUtils.assertStatementCanBeDeparsedAs;

public class AlterTest {

Expand Down Expand Up @@ -2180,4 +2193,35 @@ public void testAlterTableAlterIndexInvisible() throws JSQLParserException {

assertSqlCanBeParsedAndDeparsed(sql);
}

@Test
public void testAlterTableAddIndexInvisible() throws JSQLParserException {
String sql = "ALTER TABLE t1 ADD INDEX k_idx (k) INVISIBLE";
Statement stmt = CCJSqlParserUtil.parse(sql);
assertInstanceOf(Alter.class, stmt);

Alter alter = (Alter) stmt;
assertEquals("t1", alter.getTable().getFullyQualifiedName());

List<AlterExpression> alterExpressions = alter.getAlterExpressions();
assertNotNull(alterExpressions);
assertEquals(1, alterExpressions.size());

AlterExpression alterExp = alterExpressions.get(0);
assertEquals(AlterOperation.ADD, alterExp.getOperation());
assertNotNull(alterExp.getIndex());
assertEquals("k_idx", alterExp.getIndex().getName());
assertEquals("INDEX", alterExp.getIndex().getIndexKeyword());

List<String> columnNames = alterExp.getIndex().getColumnsNames();
assertNotNull(columnNames);
assertEquals(1, columnNames.size());
assertEquals("k", columnNames.get(0));

List<String> indexSpec = alterExp.getIndex().getIndexSpec();
assertNotNull(indexSpec);
assertTrue(indexSpec.contains("INVISIBLE"));

assertSqlCanBeParsedAndDeparsed(sql);
}
}
Loading