Skip to content

fix: allowing skyline keywords as columns, tables, etc. #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 8 commits into from
Jan 7, 2025
Merged

fix: allowing skyline keywords as columns, tables, etc. #2137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0eaab3c
fix: allowing skyline keywords as columns, tables, etc.
nicky6s Jan 5, 2025
d055332
fix: adding test clause
nicky6s Jan 5, 2025
f7952b6
fix: tweak
nicky6s Jan 5, 2025
1b015b2
fix: removing preferring
nicky6s Jan 5, 2025
fc83790
fix: clean up formatting
nicky6s Jan 5, 2025
8caa5fa
fix: updating keyword to allow low, high, inverse and plus again
nicky6s Jan 5, 2025
9eeb92f
fix: addressing review comment
nicky6s Jan 6, 2025
7108257
fix: minor revert
nicky6s Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: addressing review comment
  • Loading branch information
@nicky6s
nicky6s committed Jan 6, 2025
commit 9eeb92f0d4b5a5c7d1ab641bd92449c9e7e39195
11 changes: 7 additions & 4 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3497,10 +3497,13 @@ Expression PreferenceTermTerminal():
}
{
(
retval=HighExpression()
| retval=LowExpression()
| retval=Inverse()
| retval=Condition()
LOOKAHEAD(2) retval=HighExpression()
|
LOOKAHEAD(2) retval=LowExpression()
|
LOOKAHEAD(2) retval=Inverse()
|
retval=Condition()
)

{
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
import net.sf.jsqlparser.expression.operators.relational.GreaterThan;
import net.sf.jsqlparser.expression.operators.relational.InExpression;
import net.sf.jsqlparser.expression.operators.relational.LikeExpression;
import net.sf.jsqlparser.parser.*;
import net.sf.jsqlparser.parser.CCJSqlParserManager;
import net.sf.jsqlparser.parser.CCJSqlParserUtil;
import net.sf.jsqlparser.schema.Column;
import net.sf.jsqlparser.schema.Database;
import net.sf.jsqlparser.schema.Server;
Expand Down