Skip to content

Fix null exception in ExpressionVisitorAdapter with simple INTERVAL expression #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 1 commit into from
Dec 28, 2024
+11 −1
Merged

Fix null exception in ExpressionVisitorAdapter with simple INTERVAL expression #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix null exception in ExpressionVisitorAdapter with simple INTERVAL e… 
…xpression
  • Loading branch information
@tomershay
tomershay committed Dec 28, 2024
commit ec9a69f7991bf0b3f0626c29dfd3a0d727d4f516
5 changes: 4 additions & 1 deletion src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,10 @@ public <S> T visit(ExtractExpression extractExpression, S context) {

@Override
public <S> T visit(IntervalExpression intervalExpression, S context) {
return intervalExpression.getExpression().accept(this, context);
if (intervalExpression.getExpression() != null) {
intervalExpression.getExpression().accept(this, context);
}
return null;
}

@Override
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,4 +321,11 @@ public <S> Void visit(ExcludesExpression expr, S parameters) {
assertInstanceOf(Column.class, exprList.get(0));
assertInstanceOf(ParenthesedExpressionList.class, exprList.get(1));
}

@Test
public void testIntervalWithNoExpression() throws JSQLParserException {
Expression expr = CCJSqlParserUtil.parseExpression("INTERVAL 1 DAY");
ExpressionVisitorAdapter<Void> adapter = new ExpressionVisitorAdapter<>();
expr.accept(adapter, null);
}
}