Skip to content

fix: set stringValue in DoubleValue.setValue #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 1 commit into from
May 19, 2024
Merged

fix: set stringValue in DoubleValue.setValue #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: set stringValue in DoubleValue.setValue
  • Loading branch information
@Qnzvna
Qnzvna committed May 19, 2024
commit 2b59c26c3f8a366dcb4e9935889530a303c08c58
1 change: 1 addition & 0 deletions src/main/java/net/sf/jsqlparser/expression/DoubleValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public double getValue() {

public void setValue(Double d) {
value = d;
stringValue = String.valueOf(value);
}

@Override
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/net/sf/jsqlparser/expression/DoubleValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

public class DoubleValueTest {
Expand All @@ -28,4 +29,14 @@ public void testEmptyValue() {
new DoubleValue("");
});
}

@Test
public void shouldSetStringValue() {
final DoubleValue doubleValue = new DoubleValue("42");

doubleValue.setValue(43D);

assertEquals(43D, doubleValue.getValue());
assertEquals("43.0", doubleValue.toString());
}
}