Skip to content

feat: Add support comment in create view for MySQL and MariaDb #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 6 commits into from
Dec 14, 2023
Merged

feat: Add support comment in create view for MySQL and MariaDb #1913

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02b6f95
CreateView with comment for mysql
jxnu-liguobin Dec 14, 2023
4b84142
Add test
jxnu-liguobin Dec 14, 2023
7cad552
Fix
jxnu-liguobin Dec 14, 2023
a0a7525
Fix
jxnu-liguobin Dec 14, 2023
2c88a41
Fix
jxnu-liguobin Dec 14, 2023
72f6d86
Fix
jxnu-liguobin Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@jxnu-liguobin
jxnu-liguobin committed Dec 14, 2023
commit a0a7525736949335c5e2489749bfd4a14865f98e
14 changes: 5 additions & 9 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5713,12 +5713,8 @@ ColumnDefinition ColumnDefinitionItem():
ColumnDefinition columnWithComment = new ColumnDefinition();
}
{
( item = RelObjectName() { columnWithComment.withColumnName(item); } )
[
tk=<K_COMMENT> tk2=<S_CHAR_LITERAL> {
columnWithComment.addColumnSpecs(tk.image).addColumnSpecs(tk2.image);
}
]
( item=RelObjectName() { columnWithComment.withColumnName(item); } )
[ tk=<K_COMMENT> tk2=<S_CHAR_LITERAL> { columnWithComment.addColumnSpecs(tk.image).addColumnSpecs(tk2.image); } ]
{
return columnWithComment;
}
Expand All @@ -5731,7 +5727,7 @@ List<ColumnDefinition> ColumnDefinitionItemList():
}
{
"("
img = ColumnDefinitionItem() { retval.add(img); }
img=ColumnDefinitionItem() { retval.add(img); }
( "," img=ColumnDefinitionItem() { retval.add(img); } )*
")"
{
Expand Down Expand Up @@ -5762,8 +5758,8 @@ CreateView CreateView(boolean isUsingOrReplace):
<K_VIEW> view=Table() { createView.setView(view); }
[LOOKAHEAD(3) <K_AUTO> <K_REFRESH> (tk=<K_YES> | tk=<K_NO>) { createView.setAutoRefresh(AutoRefreshOption.from(tk.image)); } ]
[LOOKAHEAD(3) <K_IF> <K_NOT> <K_EXISTS> {createView.setIfNotExists(true);}]
[ columnNames = ColumnDefinitionItemList( ) { createView.setColumnNames(columnNames); } ]
[ commentTokens=CreateViewTailComment( ) { createView.setViewCommentOptions(commentTokens);} ]
[ columnNames=ColumnDefinitionItemList( ) { createView.setColumnNames(columnNames); } ]
[ commentTokens=CreateViewTailComment( ) { createView.setViewCommentOptions(commentTokens); } ]
<K_AS>
select=Select( ) { createView.setSelect(select); }
[ <K_WITH> <K_READ> <K_ONLY> { createView.setWithReadOnly(true); } ]
Expand Down