Tags: IntelliTect/CodingGuidelines
Tags
ci: migrate NuGet publish to trusted publishing (OIDC) (#440) ## Summary Migrates the NuGet publish step in `Deploy.yml` from a long-lived `NUGET_API_KEY` secret to OIDC-based trusted publishing via `NuGet/login@v1`. ## Changes - Added `permissions: id-token: write` to the `deploy` job (required for OIDC token issuance) - Added `NuGet/login@v1` step to exchange the OIDC token for a short-lived NuGet API key - Replaced `secrets.NUGET_API_KEY` with `steps.login.outputs.NUGET_API_KEY` in the push step ## nuget.org Setup (already done) A trusted publishing policy has been created on nuget.org for `IntelliTect.Analyzers`: - **Owner**: IntelliTect - **Repository**: CodingGuidelines - **Workflow**: `Deploy.yml` - **Environment**: `Production` ## Required Action Before Merging Add a `NUGET_USER` secret to the **Production** GitHub environment: - **Name**: `NUGET_USER` - **Value**: the nuget.org profile name (not email) of the `IntelliTect-Nuget` account ## After First Successful Publish Once a release triggers a successful publish via OIDC, the old `NUGET_API_KEY` secret can be removed from the repository secrets.
fix: INTL0101 code fix NotImplementedException for non-class declarat… …ion types (#411) ## Description Describe your changes here. Fixes #Issue_Number (if available) ### Ensure that your pull request has followed all the steps below: - [ ] Code compilation - [ ] Created tests which fail without the change (if possible) - [ ] All tests passing - [ ] Extended the README / documentation, if necessary Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skip EnsureCodeFixesProjectBuilt target when NoBuild=true dotnet pack --no-build sets NoBuild=true, which prohibits invoking the Build target. The custom EnsureCodeFixesProjectBuilt target was doing exactly that, triggering NETSDK1085. Adding the condition makes the target a no-op when the caller has already asserted everything is built.
Fix build issues introduced by recent package upgrades - Add Microsoft.Build.Framework 18.4.0 with ExcludeAssets=runtime/PrivateAssets=all to Directory.Packages.props and Integration.Tests project to resolve MSBL001 error introduced by Microsoft.Build.Locator 1.11.2 - Change GuidelineXmlToMD.Test to target net10.0 only (matching the tool project's TargetFramework) to fix NU1201 TFM compatibility restore errors - Fix pre-existing nullable reference errors now surfaced in Tools build: - GuidelineXmlFileReader.cs: null-check Root before iterating, use ?? for attributes - MdExtensions.cs: remove unnecessary ?. on already-validated str parameter - MdText.cs: use ?? string.Empty for ToString() nullable return - GuidelineXmlFileReaderTest.cs: add ! null-forgiving on Directory.GetParent chain Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>