Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Re-implement df structure: refactor len #868

Merged
densmirn merged 2 commits into from
May 29, 2020
Merged

Re-implement df structure: refactor len #868

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd588e
Re-implement df structure: refactor len
akharche May 29, 2020
5d8ea41
Undecorated all the remaining methods
densmirn May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdc/hiframes/pd_dataframe_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def df_len_overload(df):

if len(df.columns) == 0: # empty df
return lambda df: 0
return lambda df: len(df._data[0])
return lambda df: len(df._data[0][0])


# handle getitem for Tuples because sometimes df._data[i] in
Expand Down
3 changes: 1 addition & 2 deletions sdc/tests/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def test_impl(A, B, c):
c = 2
pd.testing.assert_frame_equal(hpat_func(A, B, c), test_impl(A, B, c))

@dfRefactoringNotImplemented
@unittest.skip('Implement feature to create DataFrame without column names')
def test_create_without_column_names(self):
def test_impl():
df = pd.DataFrame([100, 200, 300, 400, 200, 100])
Expand Down Expand Up @@ -2658,7 +2658,6 @@ def test_impl():
self.assertTrue(isinstance(two, np.ndarray))
self.assertTrue(isinstance(three, np.ndarray))

@dfRefactoringNotImplemented
def test_df_len(self):
def test_impl(df):
return len(df)
Expand Down