Skip to content

Implement dpnp.select - #1977

Merged
npolina4 merged 8 commits into
masterfrom
impl_select
Aug 29, 2024
Merged

npolina4 merged 8 commits into
masterfrom
impl_select

Conversation

@npolina4

@npolina4 npolina4 commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Implemented dpnp.select function.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4
npolina4 requested review from antonwolfy, vlad-perevezentsev and vtavana and removed request for antonwolfy and vlad-perevezentsev August 9, 2024 20:13
@github-actions

github-actions Bot commented Aug 9, 2024 •

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Comment thread dpnp/dpnp_iface_indexing.py
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py Outdated
Comment thread tests/test_sycl_queue.py Outdated
Comment thread tests/test_usm_type.py Outdated
Comment thread dpnp/dpnp_iface_indexing.py
Comment thread tests/test_indexing.py

@vtavana vtavana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @npolina4!

@npolina4
npolina4 merged commit f8378b0 into master Aug 29, 2024
@npolina4
npolina4 deleted the impl_select branch August 29, 2024 22:21
github-actions Bot added a commit that referenced this pull request Aug 29, 2024
* Implement dpnp.select

* Applied review comments

* Added test for select function

* removed old test for select function

---------

Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com> f8378b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants