Skip to content

Remove pyoidc and pysaml2 from core #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohe wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Remove pyoidc and pysaml2 from core #442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
baba62d
New idpyoidc based OAuth2/OIDC backend
rohe Jun 8, 2023
d8f0387
Added error message handling.
rohe Jun 8, 2023
44d02f2
Updated init attributes.
rohe Jun 8, 2023
27b8e8d
Changes as a result of Ali's testing.
rohe Jun 9, 2023
de348c5
More changes as a result of Ali Haider's testing.
rohe Jun 14, 2023
f9fdc5e
Example backend used by Ali Haider.
rohe Jun 20, 2023
e839448
Started to weed SATOSA core from saml2.
rohe Jun 23, 2023
ff23b60
Added test for idpy-oidc based backend.
rohe Aug 10, 2023
33fb01d
Also skip test_idpy_oidc.py if the idpyoidc package is not present.
rohe Aug 18, 2023
066c045
Improve configuration readability of the primary-identifier plugin
c00kiemon5ter May 16, 2023
9ccc44c
Merge branch 'master' into rm_saml2_from_core_2
rohe Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve configuration readability of the primary-identifier plugin 
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
  • Loading branch information
@c00kiemon5ter @rohe
c00kiemon5ter authored and rohe committed Aug 18, 2023
commit 066c0452f6b532dfd0de11f7e5286cd7ab7863c2
6 changes: 5 additions & 1 deletion example/plugins/microservices/primary_identifier.yaml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,24 @@ config:
- attribute_names: [eppn]
- attribute_names: [name_id]
name_id_format: urn:oasis:names:tc:SAML:2.0:nameid-format:persistent
# The line below addes the IdP entityID to the value for the SAML2
# The line below adds the IdP entityID to the value for the SAML2
# Persistent NameID to ensure the value is fully scoped.
add_scope: issuer_entityid
- attribute_names: [edupersontargetedid]
add_scope: issuer_entityid

# The internal SATOSA attribute into which to place the primary
# identifier value once found from the above configured ordered
# candidates.
primary_identifier: uid

# Whether or not to clear the input attributes after setting the
# primary identifier value.
clear_input_attributes: no

# Whether to replace subject_id with the constructed primary identifier
replace_subject_id: no

# If defined redirect to this page if no primary identifier can
# be found.
on_error: https://my.org/errors/no_primary_identifier
Expand Down
1 change: 0 additions & 1 deletion src/satosa/micro_services/primary_identifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ def constructPrimaryIdentifier(self, data, ordered_identifier_candidates):
# name_id_format add the value for the NameID of that format if it was asserted by the IdP
# or else add the value None.
if 'name_id' in candidate['attribute_names']:
candidate_nameid_value = None
candidate_nameid_value = None
candidate_name_id_format = candidate.get('name_id_format')
name_id_value = data.subject_id
Expand Down