Add mypy Pre-Commit For hi & hit Pt.10#674
Merged
daralynnrhode merged 12 commits intoJul 4, 2024
Merged
Conversation
tmplummer
approved these changes
Jul 1, 2024
Contributor
tmplummer
left a comment
There was a problem hiding this comment.
Thanks for doing this. I am learning how sloppy my type specifications are from this PR. This is valuable work for the project!
With the recommended changes to fix TODOs, the changes for Hi look good to me.
…processing into add_mypy_hi_hit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the mypy Pre-commit hook for hi & hit.
Overview
Changes for this PR will occur in the
imap_processing/hiandimap_processing/hitfiles . Applying the mypy pre-commit and making any necessary changes to then pass the checks.Please double check all function definitions and the types applied to the parameters.
With any
TODOlisted I tried to explain what error it was causing and then ignored the error in the code line.The places where inline ignore comments are will be changed/fixed before the PR is merged unless for special instances.
This one is kinda long because I could not exclude one folder without excluding the other from the checks. Sorry in advance.
New Dependencies
New Files
Deleted Files
Updated Files
-imap_processing/hit/l1a/hit_l1a.py
-imap_processing/hi/utils.py
-imap_processing/hit/l0/utils/hit_base.py
-imap_processing/hi/l1a/science_direct_event.py
-imap_processing/hi/l0/decom_hi.py
-imap_processing/hit/l0/data_classes/housekeeping.py
-imap_processing/hi/l1b/hi_l1b.py
-imap_processing/hi/l1a/hi_l1a.py
-imap_processing/hit/l1b/hit_l1b.py
-imap_processing/hit/l1a/hit_l1a.py
Testing