Fix MAG L1D test leaking CDF files: incorrect function was being patched - #3373
Open
leowerneck wants to merge 1 commit into
Open
Fix MAG L1D test leaking CDF files: incorrect function was being patched#3373leowerneck wants to merge 1 commit into
leowerneck wants to merge 1 commit into
Conversation
Author
|
I updated the description. Do I need to do anything for the CI to trigger? It says "Expected" instead of "Pending/Queued", so I wasn't sure. |
Contributor
I saw a slack message about GH actions being down right now. So I think we just have to wait for GH to fix this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Closes: #3364
Prevents the MAG L1D attribute test from leaving ancillary CDF files in the repository root.
File changes
imap_processing/tests/mag/test_mag_l1d.py: line 233 was updated to patch the appropriate"imap_processing.cli.xarray_to_cdf"function instead of"imap_processing.cdf.utils.xarray_to_cdf".Testing
Running
poetry run pytest imap_processing/tests/mag/test_mag_l1d.pyresults in all tests passing with no persistent ancillary CDF files.