SWE and SWAPI and CoDICE: Filter extra data at day boundary for L2#3194
Merged
tech3371 merged 3 commits intoMay 14, 2026
Merged
Conversation
tech3371
commented
May 13, 2026
| return vectorized_et_to_frac_doy(et) | ||
|
|
||
|
|
||
| def str_yyyymmdd_to_ttj2000ns(date_str: str) -> np.int64: |
Contributor
Author
There was a problem hiding this comment.
@lacoak21 I took your code from IDEX PR :)
Collaborator
There was a problem hiding this comment.
This is a helpful utility : )
Collaborator
|
Add CoDICE to your PR title for clarity since your update also includes changing the CoDICE L1A products |
Contributor
Author
|
I tested and check that all those three instruments are getting filter correctly and we are. Here is data I used for testing CLI. |
maxinelasp
approved these changes
May 14, 2026
b989f15
into
IMAP-Science-Operations-Center:dev
14 checks passed
Collaborator
|
The logic and tests you shared make sense. It might be worth sharing a CDF with the CoDICE team to ensure that it addresses their concerns in ticket #3062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3182 and #3062
Overview
Write generic function to filter out out of day boundary for instruments who have buffered data, especially needed for CoDICE, SWE and SWAPI.
File changes
Testing