Skip to content

GLOWS - change to int#3158

Merged
laspsandoval merged 2 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:bad_time_flag_int
May 8, 2026
Merged

GLOWS - change to int#3158
laspsandoval merged 2 commits into
IMAP-Science-Operations-Center:devfrom
laspsandoval:bad_time_flag_int

Conversation

@laspsandoval
Copy link
Copy Markdown
Contributor

This pull request updates the handling of the bad_time_flag_occurrences variable in the GLOWS L2 data processing pipeline to use an unsigned 16-bit integer type, increases its valid range, and adds a test to verify the new data type. These changes ensure the variable can represent a larger range of values and are consistent across the configuration, code, and tests.

Data type and range updates:

  • Changed the bad_time_flag_occurrences array in glows_l2_data.py to use np.uint16 for a wider valid range and better memory efficiency.
  • Updated the configuration in imap_glows_l2_variable_attrs.yaml to set FILLVAL to 65535, and changed VALIDMIN to 0 and VALIDMAX to 65535, aligning with the new data type.

Testing improvements:

  • Added a test in test_glows_l2.py to assert that bad_time_flag_occurrences uses the np.uint16 data type, ensuring correctness of the change.

@laspsandoval laspsandoval requested a review from maxinelasp May 7, 2026 20:27
@laspsandoval laspsandoval self-assigned this May 7, 2026
@laspsandoval laspsandoval added the Ins: GLOWS Related to the GLOWS instrument label May 7, 2026
@laspsandoval laspsandoval added this to IMAP May 7, 2026
@laspsandoval laspsandoval linked an issue May 7, 2026 that may be closed by this pull request
@laspsandoval laspsandoval merged commit 6709afa into IMAP-Science-Operations-Center:dev May 8, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this to Done in IMAP May 8, 2026
@laspsandoval laspsandoval deleted the bad_time_flag_int branch May 8, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ins: GLOWS Related to the GLOWS instrument

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

BUG - GLOWS L2 bad_time_flag_occurences should be an integer

2 participants