GLOWS - change to int#3158
Merged
laspsandoval merged 2 commits intoMay 8, 2026
Merged
Conversation
maxinelasp
approved these changes
May 8, 2026
6709afa
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of the
bad_time_flag_occurrencesvariable in the GLOWS L2 data processing pipeline to use an unsigned 16-bit integer type, increases its valid range, and adds a test to verify the new data type. These changes ensure the variable can represent a larger range of values and are consistent across the configuration, code, and tests.Data type and range updates:
bad_time_flag_occurrencesarray inglows_l2_data.pyto usenp.uint16for a wider valid range and better memory efficiency.imap_glows_l2_variable_attrs.yamlto setFILLVALto65535, and changedVALIDMINto0andVALIDMAXto65535, aligning with the new data type.Testing improvements:
test_glows_l2.pyto assert thatbad_time_flag_occurrencesuses thenp.uint16data type, ensuring correctness of the change.