CoDICE l2 DE: keep nso and rgfo vars#3147
Merged
lacoak21 merged 2 commits intoMay 7, 2026
Merged
Conversation
Contributor
Author
|
I just realized I didn't check for ISTP compliance. Is that ok if that gets addressed in the attribute work @tech3371 ? |
Contributor
yep. We have set CDF attrs in L1A. We can double check those attrs in L2 metadata work. I am pinging @davidt0x for awareness that we are carrying new L1A variable into L2 for CoDICE Lo DE data file. |
tech3371
approved these changes
May 6, 2026
Contributor
tech3371
left a comment
There was a problem hiding this comment.
This change looks good. I don't know why the check is failing though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #2698
Overview
Keep nso and rgfo vars in de l2.
File changes