Skip to content

Adding valueerror#3119

Merged
maxinelasp merged 2 commits into
IMAP-Science-Operations-Center:devfrom
maxinelasp:mag2830
May 4, 2026
Merged

Adding valueerror#3119
maxinelasp merged 2 commits into
IMAP-Science-Operations-Center:devfrom
maxinelasp:mag2830

Conversation

@maxinelasp
Copy link
Copy Markdown
Contributor

Change Summary

Addresses the MAG bug in #2830 and helps with a failure case described in #3060.

Just adds a value throw if no data is left after truncating to 24 hours.

@maxinelasp maxinelasp requested a review from sapols May 1, 2026 20:47
@maxinelasp maxinelasp self-assigned this May 1, 2026
@maxinelasp maxinelasp requested a review from tech3371 May 4, 2026 16:07
@sapols
Copy link
Copy Markdown
Contributor

sapols commented May 4, 2026

@maxinelasp the codecov/patch check seems to want a new unit test for this change

@maxinelasp
Copy link
Copy Markdown
Contributor Author

@sapols Yes, I just added one. Codecov..... -_-

Copy link
Copy Markdown
Contributor

@sapols sapols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxinelasp LGTM! You said this addresses #2830 and "helps with" #3060. Gonna add more later for 3060?

@maxinelasp
Copy link
Copy Markdown
Contributor Author

@sapols Yes, there will be another, similar ticket for strict checking for #3060.

@maxinelasp maxinelasp merged commit d5dd3f8 into IMAP-Science-Operations-Center:dev May 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants