ULTRA l2 map duration descriptor #3024
Merged
lacoak21 merged 2 commits intoApr 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ULTRA L2 map metadata to keep the duration/cadence label from a provided input descriptor rather than recalculating it from the PSET epoch span (fixing the mismatch described in #3019).
Changes:
- Capture the duration token from the parsed descriptor and use it for
Logical_source/related formatted metadata. - Fall back to the previous “compute duration from PSET epochs” behavior only when no descriptor is provided.
- Update the ULTRA L2 descriptor unit test to validate that output metadata retains the descriptor’s duration label even when the PSETs span a different duration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
imap_processing/ultra/l2/ultra_l2.py |
Prefer descriptor-provided duration label for output map naming/metadata; fallback to computed duration otherwise. |
imap_processing/tests/ultra/unit/test_ultra_l2.py |
Adjust descriptor-based test to assert output Logical_source matches the descriptor duration label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
980821d
into
IMAP-Science-Operations-Center:dev
14 checks passed
lacoak21
added a commit
to lacoak21/imap_processing
that referenced
this pull request
May 4, 2026
* fix ultra cadence desc * remove comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3019
Overview
Pass the cadence label from the input job descriptor to the output map descriptor. ULTRA code was recalculating the cadence label (e.g. 3mo, 6mo ect.) based on the actual psets passed into the job. This can cause unintended consequences (see linked issue).
This is updating the ULTRA code to follow what Hi and Lo are doing.
File changes
imap_processing/ultra/l2/ultra_l2.py
Testing
Update the input descriptor in the test to check that the output contains the same descriptor.