ULTRA l1a event_id update#3014
Merged
lacoak21 merged 9 commits intoMay 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ULTRA processing to generate a new per-event event_id and wires it into event packet expansion, with accompanying unit tests. The PR also includes an unrelated change to ULTRA L2 rectangular map projection configuration.
Changes:
- Reworked ULTRA L0
get_event_idto produce per-event 50-character hex string IDs and integrated it intoprocess_ultra_events. - Updated/added unit tests for the new
get_event_idbehavior and its error path. - Changed ULTRA L2 rectangular map projection to only project
ena_intensity.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| imap_processing/ultra/l0/decom_ultra.py | Implements new string-based event_id generation and attaches IDs during event expansion. |
| imap_processing/ultra/l2/ultra_l2.py | Adjusts which variables are projected when producing RECTANGULAR L2 maps. |
| imap_processing/ultra/l1a/ultra_l1a.py | Adds commented-out raw packet note (currently unused). |
| imap_processing/tests/ultra/unit/test_ultra_l1a.py | Updates tests for the revised get_event_id function signature/output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laspsandoval
approved these changes
May 1, 2026
Contributor
laspsandoval
left a comment
There was a problem hiding this comment.
A couple of things to check. Nice work!
86ddb5f to
9840133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #2823
Overview
Update the event id to contain the met AND the all the data for each event in a 50 character hex string
File changes
imap_processing/ultra/l0/decom_ultra.py
Testing
Tests for new event_id function
There will be a validation test in a future PR