Fix Lo L2 processing pointing set midpoint_j2000_et calculation#3011
Merged
tmplummer merged 1 commit intoApr 15, 2026
Conversation
Collaborator
|
This seems superficial--at first I was thinking it only differs by the clock drift. But if I'm reading it right, it would actually shift the midpoint of the pointing set time by about 5 years: start - end of 0 seconds, interpreted as a MET would be 2010-01-01, convert to seconds since J2000 is ten years, divide by two. That would probably mean no SPICE coverage as well? |
Collaborator
|
Can you run |
2cb91e2 to
7f3ebd1
Compare
tmplummer
approved these changes
Apr 15, 2026
062ea48
into
IMAP-Science-Operations-Center:dev
14 checks passed
lacoak21
pushed a commit
to lacoak21/imap_processing
that referenced
this pull request
May 4, 2026
…-Science-Operations-Center#3011) Co-authored-by: Menlo Innovations - CAVA Project <harrison@menloinnovations.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
A recent change to how the L2 ENA maps are produced means the middle time of the pointing set is used when projecting pointing set values to the SkyMap object. The middle time of the Lo pointing set was being computed incorrectly before this change. However, there are no noticeable issues when producing L2 maps with this incorrect computation, because no projection is needed when producing Lo maps in IMAP_HAE since the IMAP_HAE coords are already known by the pset.
However, because the mapping tool can generate maps in other frames (non HAE), it is possible the incorrect computation of the time used to project the pset into the skymap could cause issues in this case.
File changes
imap_processing/ena_maps/ena_maps.py
pointing_end_metandpointing_start_metto ttj2000ns before performing subtraction to compute theepoch_delta