Update glows_l1b_data.py, replace glows_time_offset with imap_time_of…#2945
Merged
Merged
Conversation
…fset glows_time_offset should be replaced here with imap_time_offset here. Both IMAP and GLOWS clock readings are included in GLOWS histogram packets, but the two clocks are separate instances and their readings should not be mixed.
maxinelasp
reviewed
Apr 24, 2026
| @@ -899,7 +899,7 @@ def update_spice_parameters(self) -> None: | |||
| data_start_met = self.imap_start_time | |||
| # use of imap_start_time and glows_time_offset is correct. | |||
Contributor
There was a problem hiding this comment.
Update or remove this comment
Comment on glows_time_offset removed as suggested by @maxinelasp
Contributor
|
I think this line in the tests needs to be updated to point to |
Modified tests after replacing glows_time_offset by imap_time_offset
maxinelasp
approved these changes
Apr 25, 2026
0f40ec5
into
IMAP-Science-Operations-Center:dev
14 checks passed
lacoak21
pushed a commit
to lacoak21/imap_processing
that referenced
this pull request
May 4, 2026
IMAP-Science-Operations-Center#2945) * Update glows_l1b_data.py, replace glows_time_offset with imap_time_offset glows_time_offset should be replaced here with imap_time_offset here. Both IMAP and GLOWS clock readings are included in GLOWS histogram packets, but the two clocks are separate instances and their readings should not be mixed. * Update glows_l1b_data.py Comment on glows_time_offset removed as suggested by @maxinelasp * Update test_glows_l1b_data.py Modified tests after replacing glows_time_offset by imap_time_offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glows_time_offset should be replaced here with imap_time_offset here. Both IMAP and GLOWS clock readings are included in GLOWS histogram packets, but the two clocks are separate instances and their readings should not be mixed.
Change Summary
Overview
One line changed to replace glows_time_offset with imap_time_offset
File changes
This part of code sets time bounds for computations of SPICE-related variables. Two clocks readings should not be mixed here.
Testing