I-ALiRT - Hit data access#2909
Merged
laspsandoval merged 2 commits intoApr 2, 2026
Merged
Conversation
lacoak21
approved these changes
Apr 2, 2026
Contributor
lacoak21
left a comment
There was a problem hiding this comment.
Nice looks good and makes sense to me.
| grouped_data["hit_met"][(grouped_data["group"] == group).values].values[0] | ||
| ) | ||
|
|
||
| status_values = grouped_data["hit_status"][ |
Contributor
There was a problem hiding this comment.
Interesting was this a duplicate check here?
Contributor
Author
There was a problem hiding this comment.
Yes. But also they want to produce data even if the status is not nominal. So that's what this ticket is about.
Contributor
There was a problem hiding this comment.
Cool yeah that part makes sense.
a1a8f60
into
IMAP-Science-Operations-Center:dev
14 checks passed
sapols
pushed a commit
to sapols/imap_processing
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
process_hitfunction inimap_processing/ialirt/l0/process_hit.pyto improve how hit groups with zero status values are handled and logged, and adjusts the corresponding unit test. The main changes group all hit groups with zero status values and log them together as a warning, rather than logging each occurrence individually and skipping processing. The test is updated to reflect the new behavior and expected output.Improvements to hit group status handling:
process_hitto collect all hit groups with zero status values in astatus_groupslist and log them together as a warning at the end, instead of logging and skipping each group immediately. This change improves logging clarity and ensures all groups are processed. [1] [2] [3]met_to_utcimport, as it is no longer needed for per-group logging.Unit test updates:
test_process_hitunit test to expect 15 processed hits (instead of 1), and to match the new expected values for the hit product, reflecting the changes in how hit groups with zero status values are handled.