Lo: Update TOF3 conversion#2864
Merged
ahotasu merged 3 commits intoMar 24, 2026
Merged
Conversation
…nce-Operations-Center#2861) Co-authored-by: ahotasu <17867545+ahotasu@users.noreply.github.com> Agent-Logs-Url: https://github.com/ahotasu/imap_processing/sessions/681b3ffc-2c41-4cd6-ba50-0ba8044a6018
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IMAP-Lo L1B TOF engineering-unit conversion behavior by revising the TOF3 conversion coefficients, aligning the conversion output with updated instrument calibration guidance.
Changes:
- Updated
TOF3_CONVcoefficients used for DN→EU conversion. - Updated the Lo L1B unit test expected values to match the new TOF3 conversion output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
imap_processing/lo/l1b/tof_conversions.py |
Updates TOF3 conversion coefficients used by Lo L1B TOF EU conversion. |
imap_processing/tests/lo/test_lo_l1b.py |
Adjusts test_convert_tofs_to_eu expected TOF3 values for the new coefficients. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sdhoyt
approved these changes
Mar 24, 2026
sapols
pushed a commit
to sapols/imap_processing
that referenced
this pull request
Apr 15, 2026
* Initial plan * ENH: Update TOF3 conversion coefficients per Lo IT request (IMAP-Science-Operations-Center#2861) Co-authored-by: ahotasu <17867545+ahotasu@users.noreply.github.com> Agent-Logs-Url: https://github.com/ahotasu/imap_processing/sessions/681b3ffc-2c41-4cd6-ba50-0ba8044a6018 * Added documentation (comment) regarding TOF3 CONV update. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ahotasu <17867545+ahotasu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Update TOF3 conversion coefficients per email from Nathan
No reprocessing of past data is required, per Nathan
Overview
File changes
tof_conversions.py: Update TOF3 conversion coefficients
test_lo_l1b.py: Update tests to match new expected output
Testing
No new tests added.