Filter empty HistogramL1A data points in GLOWS L1A processing#2756
Merged
Conversation
…dd test Co-authored-by: tech3371 <36522642+tech3371@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Filter GLOWS L1A histogram data points that are empty
Filter empty HistogramL1A data points in GLOWS L1A processing
Feb 23, 2026
Contributor
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
tech3371
approved these changes
Feb 24, 2026
maxinelasp
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some histogram packets contain timestamps with no actual data (
NBINS == 0), typically from validation data. These empty entries were being passed through the pipeline and producing spurious output records.Changes
glows_l1a.py: Filter outHistogramL1Aobjects withnumber_of_bins_per_histogram == 0at the top ofgenerate_histogram_datasetbefore any processing:test_glows_l1a_cdf.py: Addtest_generate_histogram_dataset_filters_empty— mixes mock empty histograms (number_of_bins_per_histogram == 0) with real ones and asserts only the non-empty entries appear in the output dataset.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.