SWE L1B implementation and updates to L1A#253
Merged
Conversation
greglucas
reviewed
Oct 17, 2023
77b4f8a to
0d82f6f
Compare
Contributor
Author
|
pre-commit.ci autofix |
greglucas
reviewed
Nov 15, 2023
Collaborator
greglucas
left a comment
There was a problem hiding this comment.
Don't be afraid of Path objects :) There is a lot of f"{imap_processing}/path/to/file" that could be imap_processing / "path/to/file" so you stay in the pathlib classes.
The dataset copy / indexing is something worth looking into IMO. I think we should try to return a new view into the subset dataset instead of overwriting the current one if possible.
…it hooks. Will remove it once I refactor in upcoming PRs.
- added logics to populate data based on ESA lookup table number - refactored code to store l1a data as 180x7 instead of 15x12x7 array. - added new event test data and moved tests data into folders. - updated l1a code to be ISTP compliant and to be able to create cdf file - added new test data and update test as needed - implemented SWE l1b algorithm for both science and other data types - creates cdf file for SWE l1b data product - added deadtime correction and place holder for in-flight calibration. converted counts to rates - added rest of l1b algorithm to convert raw data to engineering unit.
for more information, see https://pre-commit.ci
…rder. Added checks to look for right data
… to import that and other updates as needed. WIP: need to fix more error from this change. Will get back to it
- renamed to decompressed. fixed comments - convert everything to Path where possible - update rates functions - refactor code to use tmp_path to store test data
…atest cdf generated at runtime
greglucas
approved these changes
Nov 17, 2023
Collaborator
greglucas
left a comment
There was a problem hiding this comment.
Because you added and removed files, please squash-merge when merging this in.
5 tasks
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…nter#253) SWE L1B implementation and updates to L1A: - Added project wide utils function and swe specific utils - added logics to populate data based on ESA lookup table number - refactored code to store l1a data as 180x7 instead of 15x12x7 array. - added new event test data and moved tests data into folders. - updated l1a code to be ISTP compliant and to be able to create cdf file - added new test and update test as needed - implemented SWE l1b algorithm for both science and other data types - creates cdf file for SWE l1b data product - added deadtime correction and place holder for in-flight calibration. converted counts to rates - added rest of l1b algorithm to convert raw data to engineering unit. - updated function that write data to cdf to be more generic - changed cdf attrs to use new CDF dataclasses - change energy unit to be unitless for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Implements SWE L1B algorithm and updates L1A
Overview
These are the changes in this PR
- added logics to populate data based on ESA lookup table number
- refactored code to store l1a data as 180x7 instead of 15x12x7 array.
- added new event test data and moved tests data into folders.
- updated l1a code to be ISTP compliant and to be able to create cdf file
- added new test data and update test as needed
- implemented SWE l1b algorithm for both science and other data types
- creates cdf file for SWE l1b data product
- added deadtime correction and place holder for in-flight calibration. converted counts to rates
- added rest of l1b algorithm to convert raw data to engineering unit.
New Files
Deleted Files
Updated Files
Testing