Update frame transforms#2189
Merged
maxinelasp merged 3 commits intoSep 8, 2025
Merged
Conversation
laspsandoval
reviewed
Sep 5, 2025
laspsandoval
left a comment
Contributor
There was a problem hiding this comment.
A couple of questions. I also checked to make certain this doesn't affect I-ALiRT and it doesn't. Hooray! Nice work. I
tmplummer
reviewed
Sep 8, 2025
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
After making the below comments, it occurred to me that maybe the problem is that the singular class instance attribute self.frame cannot handle the reality that when the vectors are in their native frames, there are actually 2 different frames, one for self.vectors and one for self.magi_vectors. If that is true, maybe adding another attribute that contains the magi_frame would clean things up? Just a suggestion from my incomplete picture of this class.
laspsandoval
approved these changes
Sep 8, 2025
laspsandoval
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me. Nice work
3ca5922
into
IMAP-Science-Operations-Center:dev
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Follow on to #2177 and completes #2111
Change all references to IMAP_MAG to either IMAP_MAG_O or IMAP_MAG_I and add a test to verify.
Completes MAG L1D and MAG L2 changes for this update.