Update the pom's Java version to match the github build.#97
Conversation
a1908ec to
83e0b99
Compare
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <maven.compiler.release>21</maven.compiler.release> |
There was a problem hiding this comment.
while i am in favor of using maven.compiler.release i'm not really following the bump to 21. i thought the baseline the library should target should be low (maybe not 1.8, but perhaps 17 as that is a reasonable baseline.) raising it too high risks dropping support for people who do not upgrade to jdk's readily (even though they should).
|
@yuzawa-san , iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/SlicedCharSequence.java line 41 calls |
|
ah i see, i'll open a pr to try to use a earlier jdk |
|
ok i have a branch https://github.com/IABTechLab/iabgpp-java/compare/4.X...yuzawa-san:iabgpp-java:4.X-proper-baseline?expand=1 or if you prefer an exact commit a723c5c can you try applying that patch and setting the baseline to 11? |
This fixes local builds as described in #96.