Skip to content

kibana 6.0.0 and kibana@5.6 5.6.4 (new formula)#20638

Closed
jasontedor wants to merge 2 commits intoHomebrew:masterfrom
jasontedor:kibana-6.0.0
Closed

kibana 6.0.0 and kibana@5.6 5.6.4 (new formula)#20638
jasontedor wants to merge 2 commits intoHomebrew:masterfrom
jasontedor:kibana-6.0.0

Conversation

@jasontedor
Copy link
Copy Markdown
Contributor

@jasontedor jasontedor commented Nov 14, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@jasontedor
Copy link
Copy Markdown
Contributor Author

jasontedor commented Nov 14, 2017

Please note the kibana@5.6 formula in this PR is simply a rename of the existing formula to 5.6; as that formula is already accepted into this repository, kibana@5.6 should not need a review here.

@jasontedor jasontedor force-pushed the kibana-6.0.0 branch 2 times, most recently from 033563a to 2244198 Compare November 14, 2017 19:55
ilovezfs
ilovezfs reviewed Nov 15, 2017
View reviewed changes
Comment thread Formula/kibana.rb Outdated
Copy link
Copy Markdown
Contributor

@ilovezfs ilovezfs Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not https://nodejs.org/dist/v6.11.5/node-v6.11.5.tar.xz ?

Copy link
Copy Markdown
Contributor Author

@jasontedor jasontedor Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the source tarballs do not support make lint and the build now fails if linting is not available; see nodejs/node#13658.

Copy link
Copy Markdown
Contributor

@ilovezfs ilovezfs Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

ilovezfs
ilovezfs suggested changes Nov 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the addition of kibana@5.6 a separate commit with the commit subject kibana@5.6 5.6.4 (new formula)

@ilovezfs ilovezfs changed the title kibana 6.0.0 kibana 6.0.0 and kibana@5.6 5.6.4 (new formula) Nov 15, 2017
@ilovezfs ilovezfs added legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 15, 2017
@ilovezfs
Copy link
Copy Markdown
Contributor

ilovezfs commented Nov 15, 2017

The versioned formula needs to be keg_only :versioned_formula

ilovezfs
ilovezfs reviewed Nov 15, 2017
View reviewed changes
Comment thread Formula/kibana@5.6.rb Outdated
Copy link
Copy Markdown
Contributor

@ilovezfs ilovezfs Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottle block should be removed

Copy link
Copy Markdown
Contributor Author

@jasontedor jasontedor Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this.

@jasontedor
Copy link
Copy Markdown
Contributor Author

jasontedor commented Nov 15, 2017

I've split this into two commits as requested.

@ilovezfs
Copy link
Copy Markdown
Contributor

ilovezfs commented Nov 15, 2017 

Error: 1 problem in 1 formula
kibana@5.6:
  * C: 12: col 1: Trailing whitespace detected.

I'll fix that while pulling.

@ilovezfs
Copy link
Copy Markdown
Contributor

ilovezfs commented Nov 15, 2017

Thanks @jasontedor! 🚢'd

@ilovezfs ilovezfs closed this in ceb07bf Nov 15, 2017
@jasontedor
Copy link
Copy Markdown
Contributor Author

jasontedor commented Nov 15, 2017

Thanks @ilovezfs!

@jasontedor jasontedor deleted the kibana-6.0.0 branch November 15, 2017 16:20
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ilovezfs ilovezfs ilovezfs requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasontedor @ilovezfs