minor accessbility improvements#187
Merged
Harsh062 merged 1 commit intoNov 1, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Harsh062
commented
Nov 1, 2024
| type="button" | ||
| className="pl-2.5 text-slate-400" | ||
| aria-label={childrenVisibility ? `Collapse ${node.title}` : `Expand ${node.title}`} | ||
| aria-expanded={childrenVisibility} |
Contributor
Author
There was a problem hiding this comment.
childrenVisibility controls the visibility of child nodes in the TOC.
It toggles between true (expanded) and false (collapsed) when the user clicks the button to expand or collapse a TOC section.
Harsh062
commented
Nov 1, 2024
| aria-label={node.title} | ||
| /> | ||
| </div> | ||
| {node.hasChildren ? ( |
Contributor
Author
There was a problem hiding this comment.
hasChildren indicates if the current node has any child elements within the TOC.
This helps render the expand/collapse button only when there are child items.
devendershekhawat
approved these changes
Nov 1, 2024
hoangsvit
pushed a commit
to hoangsvit/hashnode-starter-kit
that referenced
this pull request
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.