Skip to content

hints: accept numeric keypad keys when hint chars are digits - #3875

Open
da-luce wants to merge 1 commit into
Hammerspoon:masterfrom
da-luce:hints-numpad-digit-keys
Open

da-luce wants to merge 1 commit into
Hammerspoon:masterfrom
da-luce:hints-numpad-digit-keys

Conversation

@da-luce

@da-luce da-luce commented Jun 24, 2026

Copy link
Copy Markdown

When hs.hints.hintChars is configured with digits, only the number-row keycodes get bound, so the numeric keypad keys (pad0-pad9) do nothing.

I hit this on a split keyboard where the number row lives on a layer that emits keypad keycodes--so the keypad is how I actually type a digit, and the hints modal was ignoring it.

This binds the matching padN keycode alongside each digit hint character. I can work around it by overriding hints.setupModal() in my own config, but selecting a digit hint with the digit key (wherever that digit happens to live on the keyboard) seems like it should just be the default.

When hs.hints.hintChars is configured with digits, setupModal() only
bound the number-row keycodes, so pressing the equivalent numeric keypad
key did nothing. Bind the matching padN keycode alongside each digit hint
character so the keypad selects hints too.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@da-luce
da-luce marked this pull request as ready for review June 24, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant