Repository navigation
Conversation
When hs.hints.hintChars is configured with digits, setupModal() only bound the number-row keycodes, so pressing the equivalent numeric keypad key did nothing. Bind the matching padN keycode alongside each digit hint character so the keypad selects hints too.
da-luce
marked this pull request as ready for review
June 24, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
hs.hints.hintCharsis configured with digits, only the number-row keycodes get bound, so the numeric keypad keys (pad0-pad9) do nothing.I hit this on a split keyboard where the number row lives on a layer that emits keypad keycodes--so the keypad is how I actually type a digit, and the hints modal was ignoring it.
This binds the matching
padNkeycode alongside each digit hint character. I can work around it by overridinghints.setupModal()in my own config, but selecting a digit hint with the digit key (wherever that digit happens to live on the keyboard) seems like it should just be the default.