This repository was archived by the owner on May 14, 2024. It is now read-only.
Homework week2#27
Closed
Wael-Alhomsi wants to merge 7 commits into
Closed
Conversation
harditsingh
reviewed
Jun 30, 2018
harditsingh
left a comment
There was a problem hiding this comment.
Good job Wael! Your code looks very clean and so does your website. I have some comments though, please check below
| } | ||
|
|
||
| newSelect.addEventListener('change', handleNewRepositoryRequest => { | ||
| const newUrl = 'https://api.github.com/repos/HackYourFuture/' + arrayOfObjects[event.target.value].name; |
There was a problem hiding this comment.
You should try to avoid putting URLs in multiple places
|
|
||
| function startUpAndBuildSelectList(data) { | ||
|
|
||
| const arrayOfObjects = JSON.parse(data); |
There was a problem hiding this comment.
The 404 error is not being handled properly, the code throws an exception here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.