You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 14, 2024. It is now read-only.
Hey Wael!
You homework looks pretty good, nice work! That said, there are a few problems that I found:
main(), app.js: The main() function is referring to a variable which is present outside the function, which makes the main() an impure function! You should always pass these variables as an argument instead. Also, you have put the 'covers' object inside the function which not the best thing to do.
Line 49, 78, app.js: The name 'header' is not the best choice for representing the element that will contain the book title. Similarly, 'image' is not the best variable name for storing the element which contains the image of a book cover.
style.css: I see that you have styled HTML elements h1, h2, li, img directly instead of using classes. While this is not a problem for this assignment, you might run into problems when the websites start growing in size.
Line 80, app.js: This isn't an issue but a note, I saw that you used underscores ('_') for the alt attribute. You don't really need to do that, the value of the alt attribute can contain spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.