Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

replace another link that is too hard to read#58

Merged
gijscor merged 1 commit into
masterfrom
gijscor-patch-1
Sep 19, 2018
Merged

replace another link that is too hard to read#58
gijscor merged 1 commit into
masterfrom
gijscor-patch-1

Conversation

@gijscor
Copy link
Copy Markdown
Contributor

@gijscor gijscor commented Sep 19, 2018

replaced 2 links ( from eloquent javaScript) that is too hard to read for beginners / non native english speakers.
the first I replaced it with our internal Scope documentation, that currently wasn't part of the reading (and is talked about in Eloquent JS)
the second I replaced with a clear video on expressions vs statements. I think in general it's good to be very specific about what each reading is exactly about, and what you should get understand out of it.

replaced 2 links ( from eloquent javaScript) that is too hard to read for beginners / non native english speakers. 
the first I replaced it with our internal Scope documentation, that currently wasn't part of the reading (and is talked about in Eloquent JS) 
the second I replaced with a clear video on expressions vs statements. I think in general it's good to be very specific about what each reading is exactly about, and what you should get understand out of it.
Copy link
Copy Markdown
Contributor

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gijscor, these are useful improvements. But note that we have more links to Eloquent JavaScript in later modules, replacing the outdated A Smarter Way.... I think that at some point (not necessarily at this early stage) our students should be able to read more technically worded material such as Eloquent JavaScript, if they are to become self-supporting.

@gijscor
Copy link
Copy Markdown
Contributor Author

gijscor commented Sep 19, 2018

@remarcmij I agree that students will at some point will have to understand more complex ways of writing, but the question is when that is. I think its more important to make sure they understand the fundamentals well in simple language, before we start exposing them to more complex texts that refer to those fundamentals. My impression now is that when you expose students to these complex texts too early, the information is simply not digested in any form.

@gijscor gijscor merged commit 2004fd4 into master Sep 19, 2018
@M3kH
Copy link
Copy Markdown
Member

M3kH commented Sep 19, 2018

I’m afraid that these desicion shouldn’t be rush to be merge.

Replacing one reference to another one is a matter of common agreement and is especially valuable to take in count what other teachers of JavaScript module thinks about.

Merging this PR with haim to remove the references on Eloquent JavaScript for me is a not go; especially if we didn’t evaluate the topic it self.

@gijscor
Copy link
Copy Markdown
Contributor Author

gijscor commented Sep 20, 2018

@M3kH I understand your point, I will give it a bit more time for feedback next time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants