This repository was archived by the owner on May 14, 2024. It is now read-only.
corrections of outdated information#56
Merged
Merged
Conversation
Step 1 made no sense, as they refer to previous javaScript exercises, whereas in week 1 they haven't done any JavaScript exercises yet. Step 2 also doesn't really makes sense as the students don't yet hand in their homework using pull requests, so commenting can only be done by making an issue, which is not the common way of commenting on code. I think it's much better to do this at a later stage when they make pull requests
remarcmij
approved these changes
Sep 18, 2018
Contributor
remarcmij
left a comment
There was a problem hiding this comment.
LGTM
Note that while it is possible to give feedback via an issue in each student's repo (they have one for their HTML/CSS homework; it doesn't require a PR), it is probably premature to expect that at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 made no sense, as they refer to previous javaScript exercises, whereas in week 1 they haven't done any JavaScript exercises yet.
Step 2 also doesn't really makes sense as the students don't yet hand in their homework using pull requests, so commenting can only be done by making an issue, which is not the common way of commenting on code. I think it's much better to do this at a later stage when they make pull requests