Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

moved readings to corresponding weeks#44

Merged
mkruijt merged 2 commits into
HackYourFuture:masterfrom
mkruijt:master
Mar 20, 2018
Merged

moved readings to corresponding weeks#44
mkruijt merged 2 commits into
HackYourFuture:masterfrom
mkruijt:master

Conversation

@mkruijt
Copy link
Copy Markdown
Member

@mkruijt mkruijt commented Mar 19, 2018

No description provided.

@mkruijt mkruijt requested a review from a team March 19, 2018 09:19
Copy link
Copy Markdown
Contributor

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some links that need to be fixed.

Comment thread Week0/README.md
@@ -1,13 +0,0 @@
# Reading material for your first JavaScript lesson:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to this README from the main README is broken.

In addition the link to JavaScript Fundamentals README as the bottom of the main README is broken.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is correct, I removed the file and forgot to remove Week0 in the planning

Comment thread Week3/README.md Outdated
- [Values](./../../../../fundamentals/blob/master/fundamentals/values.md)
- [Operators](./../../../../fundamentals/blob/master/fundamentals/operators.md)
- [Naming conventions](./../../../../fundamentals/blob/master/fundamentals/naming_conventions.md)
- [Naming conventions](../fundamentals/naming_conventions.md)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need some extra ../ to fix this broken link.

Comment thread Week3/MAKEME.md
_Deadline Sunday morning_

Go through the reading material in the [README.md](/Week2/README.md) to prepare for your next class
Go through the reading material in the [README.md](./../../../../JavaScript3/tree/master/Week1) to prepare for your next class
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should point to the JavaScript2 repo README

Copy link
Copy Markdown
Contributor

@remarcmij remarcmij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okidoki!

@mkruijt mkruijt merged commit 7db2f1f into HackYourFuture:master Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants