Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Update README.md#33

Merged
mkruijt merged 2 commits into
HackYourFuture:masterfrom
Kemirdin:patch-1
Feb 6, 2018
Merged

Update README.md#33
mkruijt merged 2 commits into
HackYourFuture:masterfrom
Kemirdin:patch-1

Conversation

@Kemirdin
Copy link
Copy Markdown
Contributor

@Kemirdin Kemirdin commented Feb 5, 2018

I have read this article and I found it very nice for good understanding JavaScript especially for beginners.

 I have read this article and I found it very nice for good understanding promises especially for beginners.
@Kemirdin
Copy link
Copy Markdown
Contributor Author

Kemirdin commented Feb 5, 2018

hi, I just would like to contribute some article and share with HYF, I don't know it didn't work.

Copy link
Copy Markdown
Member

@mkruijt mkruijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kemirdin cool that you are contributing, and yes you always have to make a pr! (the master branch is protected)

Comment thread Week1/README.md Outdated

- Helpful resource: http://jsbooks.revolunet.com/ (here you can find tons of free JavaScript books online)

-You are here: Home / Learn To Program / The 50 Best Websites to Learn JavaScript
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Kemirdin thanks for your contribution. Can you delete this line? I don't get why it says "You are here: Home / Learn To Program / " besides that i think it is a good resource to add. I you modify it I will merge your PR

delete this line
Copy link
Copy Markdown
Contributor Author

@Kemirdin Kemirdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's my pleasure share and contribute.thanks for the merge, I have deleted that line.

@Kemirdin
Copy link
Copy Markdown
Contributor Author

Kemirdin commented Feb 6, 2018

it's my pleasure share and contribute.thanks for the merge, I have deleted that line.

Copy link
Copy Markdown
Member

@mkruijt mkruijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mkruijt mkruijt merged commit 360e52e into HackYourFuture:master Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants