Conversation
Many of our repos run integration / system tests on Travis. These require access to credentials to run, so they must be run from a branch instead of fork. Also, so that we aren't creating a new branch every day, push to a constant branch name instead of a new branch. (I forget why I wasn't doing this in the first place.)
| fi | ||
|
|
||
| BRANCH="repositorygardener$(date +"%Y%m%d")b${RANDOM}" | ||
| BRANCH="dpebot-repositorygardener" |
There was a problem hiding this comment.
It'd be nice to be able to set this from the calling script - we may want to automate PRs for more than just updating deps.
Contributor
Author
There was a problem hiding this comment.
Agreed. I'll add an argument to the script.
15831c0 to
8e5e690
Compare
This will be useful if we make scripts for more than just updating dependencies. That way they can send different PRs for different things. Also, require the GitHub user name in the repository arguments. This will let us clone repos not just in the GoogleCloudPlatform org.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of our repos run integration / system tests on Travis. These
require access to credentials to run, so they must be run from a branch
instead of fork.
Also, so that we aren't creating a new branch every day, push to a
constant branch name instead of a new branch. (I forget why I wasn't
doing this in the first place.)
Example PR: GoogleCloudPlatform/java-docs-samples#285