Skip IoT tests, add deprecation notice to readme#9498
Merged
Conversation
nicain
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an issue to track their upcoming removal #9495, but I want to propose skipping IoT tests until then. Some flakiness with those tests has been blocking merging of dependency PRs, and I don't think our time is best spent adding retries to something that is slated for removal later this year. I believe that they are hanging in 3.11, causing #9437 to timeout
If folks aren't ready for this though and think we should wait on this til August, that's fine, just let me know