Move samples of GAE Flex Python 3.8 and later to ./flexible by jinglundong · Pull Request #9260 · GoogleCloudPlatform/python-docs-samples

jinglundong · 2023-03-10T02:27:04Z

Move samples of GAE Flex Python 3.8 and later to ./flexible.
Update README.md files and some references. Keep the Python 3.7 and earlier examples from ./flexible directory because user guide (non-English) are still using them.

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.9 (see Test Environment Setup). Couldn't test ./storage locally. It should pass the github CI.
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
Please merge this PR for me once it is approved.
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample

…le directory. Update README.md files and some references. Remove the Python 3.7 and earlier examples from ./flexible directory.

snippet-bot · 2023-03-10T02:27:11Z

Here is the summary of changes.

You are about to delete 3 region tags.

appengine/flexible_ubuntu/hello_world/main.py:15, tag gae_flex_quickstart
appengine/flexible_ubuntu/storage/app.yaml:25, tag gae_flex_storage_yaml
appengine/flexible_ubuntu/storage/main.py:15, tag gae_flex_ubuntu_storage_app

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

jinglundong · 2023-03-10T02:29:08Z

This is step 3 of the chain of changes.

1. Code sample change - Copy existing apps from appengine/flexible to appengine/flexible_python37_and_earlier. Don't touch the flexible_ubuntu at this point. 
2. Docs change - Update code references from appengine/flexible to appengine/flexible_python37_and_earlier. 
3. Code sample change - Update appengine/flexible/hello_world and appengine/flexible/storage, so they use python 3.8. 
4. Docs change - Announce GA. Need to reference appengine/flexible/storage and appengine/flexible_python37_and_earlier/storage. For the create an app page, we only need to reference the new sample reference appengine/flexible/hello_world

…avior.

jinglundong · 2023-03-10T21:32:41Z

I'm not very familiar with the review process of Github PRs. It appears that this PR needs two approving reviews. I'm not sure who are the reviewers though. Also not sure if they have been notified. Could someone help me understand the current situation?

jinglundong · 2023-03-13T18:05:02Z

Friendly ping.

engelke

LGTM. Snippet checks are being handled elsewhere.

jinglundong · 2023-03-14T22:37:08Z

FYI, we are addressing the pointers from "legacy" docs to these tags at cl/515073377.

jinglundong · 2023-03-15T20:16:11Z

The prerequisite cl/515073377 has been submitted and pushed to prod. Please let me merge this PR when you have time @nicain.

…Also updated copyrights blocks.

dandhlee

Copyright years should reflect when the file was first introduced, not the current year. Please revert any changes to years.

dandhlee

A bit more changes...

…8n user guide.

dandhlee

LGTM.

jinglundong · 2023-03-15T23:35:11Z

We made it! Thanks for reviewing this PR.

Move samples of GAE Flex Python 3.8 and later to the default ./flexib…

9d819ce

…le directory. Update README.md files and some references. Remove the Python 3.7 and earlier examples from ./flexible directory.

jinglundong requested review from a team and glasnt as code owners March 10, 2023 02:27

product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Mar 10, 2023

blunderbuss-gcf Bot assigned dandhlee Mar 10, 2023

jinglundong requested review from dandhlee and iennae March 10, 2023 02:27

jinglundong assigned iennae and dandhlee and unassigned dandhlee Mar 10, 2023

jinglundong added 3 commits March 10, 2023 02:34

Remove the runtime_version because we want to promote the :latest beh…

6d73920

…avior.

Update the tag to gae_flex_storage_app.

4cdf7dd

Merge branch 'main' into move-to-default

87e0406

jinglundong unassigned iennae and dandhlee Mar 10, 2023

engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2023

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2023

engelke approved these changes Mar 13, 2023

View reviewed changes

nicain approved these changes Mar 13, 2023

View reviewed changes

Merge branch 'main' into move-to-default

a11c5a1

jinglundong closed this Mar 15, 2023

jinglundong reopened this Mar 15, 2023

Merge branch 'main' into move-to-default

166f4a0

blunderbuss-gcf Bot assigned vchudnov-g Mar 15, 2023

jinglundong added 2 commits March 15, 2023 22:42

Add python 3.11 sample apps for Flex tasks, static files and pubsub. …

e1bb524

…Also updated copyrights blocks.

Update some code path references.

ad35969

dandhlee requested changes Mar 15, 2023

View reviewed changes

Comment thread appengine/flexible/hello_world/app.yaml Outdated

Revert the changes to the copyright year.

b7b376b

dandhlee requested changes Mar 15, 2023

View reviewed changes

dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Mar 15, 2023

jinglundong added 2 commits March 15, 2023 23:13

Revert copyright year in tasks.

4152206

Add the previous samples back, because they are still referenced by i…

ac27846

…8n user guide.

dandhlee requested changes Mar 15, 2023

View reviewed changes

Comment thread appengine/flexible/tasks/Dockerfile Outdated

Comment thread appengine/flexible/tasks/templates/index.html Outdated

snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Mar 15, 2023

Fix a few more copyright years.

06bd561

dandhlee reviewed Mar 15, 2023

View reviewed changes

Comment thread appengine/flexible/storage/noxfile_config.py

dandhlee approved these changes Mar 15, 2023

View reviewed changes

jinglundong merged commit 7f491f2 into main Mar 15, 2023

jinglundong deleted the move-to-default branch March 15, 2023 23:33

Conversation

jinglundong commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

snippet-bot Bot commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinglundong commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinglundong commented Mar 10, 2023

Uh oh!

jinglundong commented Mar 13, 2023

Uh oh!

engelke left a comment

Choose a reason for hiding this comment

Uh oh!

jinglundong commented Mar 14, 2023

Uh oh!

jinglundong commented Mar 15, 2023

Uh oh!

dandhlee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dandhlee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dandhlee left a comment

Choose a reason for hiding this comment

Uh oh!

jinglundong commented Mar 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jinglundong commented Mar 10, 2023 •

edited

Loading

snippet-bot Bot commented Mar 10, 2023 •

edited

Loading

jinglundong commented Mar 10, 2023 •

edited

Loading