docs(samples): Changing machine type sample#9042
Merged
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
savijatv
reviewed
Jan 26, 2023
kweinmeister
approved these changes
Jan 31, 2023
rsamborski
approved these changes
Feb 2, 2023
dandhlee
reviewed
Feb 3, 2023
|
|
||
|
|
||
| # <INGREDIENT change_machine_type> | ||
| def change_machine_type(project_id: str, zone: str, instance_name: str, new_machine_type: str) -> NoReturn: |
Collaborator
There was a problem hiding this comment.
Why not just None? Is NoReturn necessary?
Contributor
Author
There was a problem hiding this comment.
You are right, I'm using NoReturn here incorrectly now that I checked the documentation. I'll fix this.
|
|
||
| wait_for_extended_operation(operation, "changing machine type") | ||
|
|
||
| return |
Collaborator
There was a problem hiding this comment.
Is the return necessary? (the code will work identical without the return)
Contributor
Author
There was a problem hiding this comment.
It's not necessary, it's my personal preference to put it there, like a period at the end of a sentence :D I'll remove it.
…pe.py Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* docs(samples): Changing machine type sample * Applying suggestions * Wording fix * Update compute/client_library/ingredients/instances/change_machine_type.py Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com> * Applying suggestions --------- Co-authored-by: Karl Weinmeister <11586922+kweinmeister@users.noreply.github.com> Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)